From: Florian Haas <florian.haas@linbit.com>
To: drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH 1/2] add extra paragraph about manpages/ directory
Date: Fri, 08 Jul 2011 16:01:39 +0200 [thread overview]
Message-ID: <4E170DC3.4000401@linbit.com> (raw)
In-Reply-To: <1310053461-15060-1-git-send-email-mrten+drbd@ii.nl>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
Erm, NACK. :) That way to build the man pages is now obsolete. Thanks a
lot for the patch nonetheless, it highlighted an important omission.
I've fixed the README for the right way to do this now.
And as an aside, when a make variable is defined with "?=" as opposed to
":=", then it's meant to be overridden from the environment. Thus, even
when building the old way, you could have just done
make <target> DRBD=/path/to/drbd/checkout
... rather than hacking the Makefile.
Cheers,
Florian
On 07/07/2011 05:44 PM, Mrten wrote:
> ---
> README.txt | 13 +++++++++++++
> 1 files changed, 13 insertions(+), 0 deletions(-)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2011-07-08 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 15:44 [Drbd-dev] [PATCH 1/2] add extra paragraph about manpages/ directory Mrten
2011-07-07 15:44 ` [Drbd-dev] [PATCH 2/2] expand section on throughput tuning to highlight prime usecase of external metadata Mrten
2011-07-08 14:17 ` Florian Haas
2011-07-08 18:37 ` Mrten
2011-07-08 14:01 ` Florian Haas [this message]
2011-07-08 14:45 ` [Drbd-dev] [PATCH 1/2] add extra paragraph about manpages/ directory Florian Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E170DC3.4000401@linbit.com \
--to=florian.haas@linbit.com \
--cc=drbd-dev@lists.linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox