From: Boaz Harrosh <bharrosh@panasas.com>
To: Kent Overstreet <koverstreet@google.com>
Cc: axboe@kernel.dk, dm-devel@redhat.com, neilb@suse.de,
linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org,
mpatocka@redhat.com, vgoyal@redhat.com, yehuda@hq.newdream.net,
tj@kernel.org, sage@newdream.net, agk@redhat.com,
drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH v4 09/12] block: Rework bio_pair_split()
Date: Wed, 25 Jul 2012 15:03:30 +0300 [thread overview]
Message-ID: <500FE092.6010108@panasas.com> (raw)
In-Reply-To: <1343160689-12378-10-git-send-email-koverstreet@google.com>
On 07/24/2012 11:11 PM, Kent Overstreet wrote:
> This changes bio_pair_split() to use the new bio_split() underneath,
> which gets rid of the single page bio limitation. The various callers
> are fixed up for the slightly different struct bio_pair, and to remove
> the unnecessary checks.
>
> Signed-off-by: Kent Overstreet <koverstreet@google.com>
<snip>
> +
> +extern struct bio *bio_split(struct bio *bio, int sectors,
> + gfp_t gfp, struct bio_set *bs);
nit:
Just for taking pride in my work, I'd move this extern declaration
to the previous patch that actually introduces it.
Cheers
Boaz
> extern struct bio_pair *bio_pair_split(struct bio *bi, int first_sectors);
> extern void bio_pair_release(struct bio_pair *dbio);
>
> @@ -512,7 +514,6 @@ extern int bio_integrity_prep(struct bio *);
> extern void bio_integrity_endio(struct bio *, int);
> extern void bio_integrity_advance(struct bio *, unsigned int);
> extern void bio_integrity_trim(struct bio *, unsigned int, unsigned int);
> -extern void bio_integrity_split(struct bio *, struct bio_pair *, int);
> extern int bio_integrity_clone(struct bio *, struct bio *, gfp_t, struct bio_set *);
> extern int bioset_integrity_create(struct bio_set *, int);
> extern void bioset_integrity_free(struct bio_set *);
> @@ -556,12 +557,6 @@ static inline int bio_integrity_clone(struct bio *bio, struct bio *bio_src,
> return 0;
> }
>
> -static inline void bio_integrity_split(struct bio *bio, struct bio_pair *bp,
> - int sectors)
> -{
> - return;
> -}
> -
> static inline void bio_integrity_advance(struct bio *bio,
> unsigned int bytes_done)
> {
next prev parent reply other threads:[~2012-07-26 9:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 20:11 [Drbd-dev] [PATCH v4 00/12] Block cleanups Kent Overstreet
2012-07-24 20:11 ` [Drbd-dev] [PATCH v4 01/12] block: Generalized bio pool freeing Kent Overstreet
2012-07-25 11:06 ` Boaz Harrosh
2012-07-25 23:38 ` Kent Overstreet
2012-07-24 20:11 ` [Drbd-dev] [PATCH v4 02/12] dm: Use bioset's front_pad for dm_rq_clone_bio_info Kent Overstreet
2012-07-24 20:11 ` [Drbd-dev] [PATCH v4 03/12] block: Add bio_reset() Kent Overstreet
2012-07-25 11:19 ` Boaz Harrosh
2012-07-25 22:56 ` Kent Overstreet
2012-07-24 20:11 ` [Drbd-dev] [PATCH v4 04/12] pktcdvd: Switch to bio_kmalloc() Kent Overstreet
2012-07-25 11:29 ` Boaz Harrosh
2012-07-25 23:01 ` Kent Overstreet
2012-07-24 20:11 ` [Drbd-dev] [PATCH v4 05/12] block: Kill bi_destructor Kent Overstreet
2012-07-25 11:39 ` Boaz Harrosh
2012-07-25 23:15 ` Kent Overstreet
2012-07-24 20:11 ` [Drbd-dev] [PATCH v4 06/12] block: Add an explicit bio flag for bios that own their bvec Kent Overstreet
2012-07-24 20:11 ` [Drbd-dev] [PATCH v4 07/12] block: Rename bio_split() -> bio_pair_split() Kent Overstreet
2012-07-24 20:11 ` [Drbd-dev] [PATCH v4 08/12] block: Introduce new bio_split() Kent Overstreet
2012-07-25 11:55 ` Boaz Harrosh
2012-07-25 23:26 ` Kent Overstreet
2012-07-27 0:50 ` [Drbd-dev] [PATCH] A possible deadlock with stacked devices (was: [PATCH v4 08/12] block: Introduce new bio_split()) Mikulas Patocka
2012-08-15 23:07 ` Kent Overstreet
2012-07-24 20:11 ` [Drbd-dev] [PATCH v4 09/12] block: Rework bio_pair_split() Kent Overstreet
2012-07-25 12:03 ` Boaz Harrosh [this message]
2012-07-24 20:11 ` [Drbd-dev] [PATCH v4 10/12] block: Add bio_clone_kmalloc() Kent Overstreet
2012-07-25 12:05 ` Boaz Harrosh
2012-07-24 20:11 ` [Drbd-dev] [PATCH v4 11/12] block: Add bio_clone_bioset() Kent Overstreet
2012-07-24 20:11 ` [Drbd-dev] [PATCH v4 12/12] block: Only clone bio vecs that are in use Kent Overstreet
2012-08-07 3:17 ` Muthu Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500FE092.6010108@panasas.com \
--to=bharrosh@panasas.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=koverstreet@google.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=neilb@suse.de \
--cc=sage@newdream.net \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
--cc=yehuda@hq.newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox