From: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
To: Arnd Bergmann <arnd@kernel.org>,
Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Jens Axboe <axboe@kernel.dk>, Jakub Kicinski <kuba@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
drbd-dev@lists.linbit.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, drbd-dev@lists.linux.dev
Subject: Re: [PATCH] drbd: remove unused drbd_nl_mcgrps[] array
Date: Tue, 19 May 2026 22:51:44 +0200 [thread overview]
Message-ID: <65088b94-a603-4e84-8601-0663f85303b9@linbit.com> (raw)
In-Reply-To: <20260519203057.1340528-1-arnd@kernel.org>
On 5/19/26 22:30, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> After the rework, two files have a copy of drbd_nl_mcgrps[], but one
> of them has no references:
>
> drivers/block/drbd/drbd_nl_gen.c:641:42: error: 'drbd_nl_mcgrps' defined but not used [-Werror=unused-const-variable=]
> 641 | static const struct genl_multicast_group drbd_nl_mcgrps[] = {
> | ^~~~~~~~~~~~~~
>
> At the default warning level, -Wunused-const-variables is turned off,
> so this has gone unnoticed.
>
> Remove the extra variable.
>
> Fixes: 8098eeb693c4 ("drbd: replace genl_magic with explicit netlink serialization")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Oops, looks like a copy/paste error on my side.
Thanks for noticing and fixing.
Reviewed-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
parent reply other threads:[~2026-05-19 20:51 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20260519203057.1340528-1-arnd@kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65088b94-a603-4e84-8601-0663f85303b9@linbit.com \
--to=christoph.boehmwalder@linbit.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=drbd-dev@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox