From: Benjamin Coddington <bcodding@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
samba-technical@lists.samba.org,
Dominique Martinet <asmadeus@codewreck.org>,
Valentina Manea <valentina.manea.m@gmail.com>,
linux-nvme@lists.infradead.org,
Philipp Reisner <philipp.reisner@linbit.com>,
David Howells <dhowells@redhat.com>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Eric Dumazet <edumazet@google.com>,
linux-nfs@vger.kernel.org, Marc Dionne <marc.dionne@auristor.com>,
Shuah Khan <shuah@kernel.org>,
linux-afs@lists.infradead.org,
Mike Christie <michael.christie@oracle.com>,
drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org,
Sagi Grimberg <sagi@grimberg.me>,
linux-scsi@vger.kernel.org, Mark Fasheh <mark@fasheh.com>,
cluster-devel@redhat.com,
Christine Caulfield <ccaulfie@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
Paolo Abeni <pabeni@redhat.com>, Anna Schumaker <anna@kernel.org>,
Eric Van Hensbergen <ericvh@gmail.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Josef Bacik <josef@toxicpanda.com>,
nbd@other.debian.org, linux-block@vger.kernel.org,
David Teigland <teigland@redhat.com>,
Joel Becker <jlbec@evilplan.org>,
v9fs-developer@lists.sourceforge.net,
Keith Busch <kbusch@kernel.org>,
ceph-devel@vger.kernel.org, Xiubo Li <xiubli@redhat.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Jens Axboe <axboe@kernel.dk>, Chris Leech <cleech@redhat.com>,
open-iscsi@googlegroups.com,
"Martin K. Petersen" <martin.petersen@oracle.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
Jeff Layton <jlayton@kernel.org>,
linux-kernel@vger.kernel.org, Steve French <sfrench@samba.org>,
Chuck Lever <chuck.lever@oracle.com>,
Lee Duncan <lduncan@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
"David S. Miller" <davem@davemloft.net>,
ocfs2-devel@oss.oracle.com
Subject: Re: [Drbd-dev] [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag
Date: Tue, 29 Nov 2022 11:47:47 -0500 [thread overview]
Message-ID: <794DBAB0-EDAF-4DA2-A837-C1F99916BC8E@redhat.com> (raw)
In-Reply-To: <20221129140242.GA15747@lst.de>
On 29 Nov 2022, at 9:02, Christoph Hellwig wrote:
> Hmm. Having to set a flag to not accidentally corrupt per-task
> state seems a bit fragile. Wouldn't it make sense to find a way to opt
> into the feature only for sockets created from the syscall layer?
It's totally fragile, and that's why it's currently broken in production.
The fragile ship sailed when networking decided to depend on users setting
the socket's GFP_ flags correctly to avoid corruption.
Meantime, this problem needs fixing in a way that makes everyone happy.
This fix doesn't make it less fragile, but it may (hopefully) address the
previous criticisms enough that something gets done to fix it.
Ben
next prev parent reply other threads:[~2022-11-29 16:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1669036433.git.bcodding@redhat.com>
2022-11-21 13:35 ` [Drbd-dev] [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag Benjamin Coddington
2022-11-21 13:56 ` David Howells
2022-11-21 14:34 ` Benjamin Coddington
2022-11-21 21:40 ` Shuah Khan
2022-11-21 21:43 ` Shuah Khan
2022-11-21 22:01 ` Benjamin Coddington
2022-11-21 22:32 ` Shuah Khan
2022-11-22 14:23 ` Benjamin Coddington
2022-11-29 14:02 ` Christoph Hellwig
2022-11-29 16:47 ` Benjamin Coddington [this message]
2022-11-30 12:07 ` Guillaume Nault
2022-11-29 17:42 ` Jeff Layton
2022-11-30 11:48 ` Guillaume Nault
2022-12-09 12:37 ` Paolo Abeni
2022-12-09 16:11 ` Jakub Kicinski
2022-12-09 16:50 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=794DBAB0-EDAF-4DA2-A837-C1F99916BC8E@redhat.com \
--to=bcodding@redhat.com \
--cc=anna@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=axboe@kernel.dk \
--cc=ccaulfie@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=chuck.lever@oracle.com \
--cc=cleech@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=edumazet@google.com \
--cc=ericvh@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=idryomov@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=josef@toxicpanda.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=kbusch@kernel.org \
--cc=kuba@kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=lduncan@suse.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=marc.dionne@auristor.com \
--cc=mark@fasheh.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=nbd@other.debian.org \
--cc=netdev@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=open-iscsi@googlegroups.com \
--cc=pabeni@redhat.com \
--cc=philipp.reisner@linbit.com \
--cc=sagi@grimberg.me \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=shuah@kernel.org \
--cc=teigland@redhat.com \
--cc=trond.myklebust@hammerspace.com \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=valentina.manea.m@gmail.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox