From: John Garry <john.g.garry@oracle.com>
To: Zhang Yi <yi.zhang@huaweicloud.com>,
linux-block@vger.kernel.org, linux-raid@vger.kernel.org,
drbd-dev@lists.linbit.com
Cc: axboe@kernel.dk, martin.petersen@oracle.com, yi.zhang@huawei.com,
yangerkun@huawei.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, yukuai3@huawei.com, hch@lst.de
Subject: Re: [PATCH 1/2] md: init queue_limits->max_hw_wzeroes_unmap_sectors parameter
Date: Wed, 10 Sep 2025 10:01:26 +0100 [thread overview]
Message-ID: <7956f88a-310c-48b1-9252-23d843d932df@oracle.com> (raw)
In-Reply-To: <70c56bd4-89b0-41b8-8ac5-c38ac97319ca@huaweicloud.com>
On 10/09/2025 09:55, Zhang Yi wrote:
>> It would be better if we documented why we cannot support this on raid1/10, yet we can on raid0.
>>
>> I am looking through the history of why max_write_zeroes_sectors is set to zero. I have gone as far back as 5026d7a9b, and this tells us that the retry mechanism for WRITE SAME causes an issue where mirrors are offlined (and so we disabled the support); and this was simply copied for write zeroes in 3deff1a70.
> Yes, as discussed with Kuai, it's better to add TODO comments for
> RAID 1, 10, and 5 for now, and we can support them by properly
> propagating unsupported errors to the upper layers. I can send out
> a separate patch to add this comment.
Sure, adding a comment would be good, detailing the technical challenge
in supporting it.
For now, this series should go in ASAP.
next prev parent reply other threads:[~2025-09-10 9:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 8:50 [PATCH 0/2] Fix the initialization of max_hw_wzeroes_unmap_sectors for stacking drivers Zhang Yi
2025-08-25 8:51 ` [PATCH 2/2] drbd: init queue_limits->max_hw_wzeroes_unmap_sectors parameter Zhang Yi
2025-08-25 8:51 ` [PATCH 1/2] md: " Zhang Yi
2025-08-25 8:59 ` Paul Menzel
2025-08-25 11:25 ` Zhang Yi
2025-08-25 9:10 ` Li Nan
2025-09-02 12:25 ` John Garry
2025-09-10 8:31 ` Yu Kuai
2025-09-10 8:55 ` Zhang Yi
2025-09-10 9:01 ` John Garry [this message]
2025-08-25 19:54 ` [PATCH 0/2] Fix the initialization of max_hw_wzeroes_unmap_sectors for stacking drivers Martin K. Petersen
2025-08-26 0:44 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7956f88a-310c-48b1-9252-23d843d932df@oracle.com \
--to=john.g.garry@oracle.com \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yi.zhang@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox