From: "Kiselev, Oleg" <okiselev@amazon.com>
To: Philipp Reisner <philipp.reisner@linbit.com>,
Jens Axboe <axboe@kernel.dk>
Cc: "Herrenschmidt, Benjamin" <benh@amazon.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
"Smith, Stewart" <trawets@amazon.com>,
Christoph Hellwig <hch@lst.de>,
"drbd-dev@lists.linbit.com" <drbd-dev@lists.linbit.com>
Subject: Re: [Drbd-dev] state of drbd in mainline
Date: Wed, 30 Mar 2022 19:31:32 +0000 [thread overview]
Message-ID: <7AD2D6DC-0609-42F9-A481-B6E5C0F58180@amazon.com> (raw)
In-Reply-To: <CADGDV=WcTSSC70yG61dazo-WyoLOzp3r+nOk-Eg2x_Ncx=3nRg@mail.gmail.com>
AWS RDS is a major user of drbd. We are probably responsible for the substantial percentage of drbd users in the world. We are currently on drbd-8.4. We will eventually migrate to drbd-9, but at our scale this isn't going to happen very soon.
The last time we needed to patch drbd was back in 2018. We've not diagnosed any reportable issues with drbd-8.4 in the past ~4 years. It's a stable, mature driver. We would prefer for drbd-8 to continue being available in the upstream tree. We'd also welcome drbd-9 being available in-tree as soon as possible: it will make life much easier for other AWS teams that are currently working on DRBD deployment.
On 3/30/22, 8:24 AM, "drbd-dev-bounces@lists.linbit.com on behalf of Philipp Reisner" <drbd-dev-bounces@lists.linbit.com on behalf of philipp.reisner@linbit.com> wrote:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> > Jens, my intention is to keep it in-tree, and at some point update it.
> > Regarding your questions:
>
> That'd be great, but it's been years since there was any significant
> updates to the in-kernel drbd... I would strongly suggest that the
> in-kernel be brought closer to what people are mostly running, as it
> stands it's basically unmaintained.
The changes we worked on over many Years in the more recent drbd-9.x
branches are just too fundamental to do them in small chunks, we could
upstream bit by bit. We need to get that reviewed in a big series. If I
started to dump them on linux-block right away, nobody would look at it
seriously, since it would be too much. I intend to get people from red
hat/suse assigned to do such a review. Then we will do that on linux-block,
so that everyone who cares sees what happens.
[...]
> The main discrepancy here is that there are apparently huge numbers of
> in-tree users, yet no fixes or patches at all making it to mainline.
> Either drbd is bug free and doesn't require any fixes at all, which I
> very much would doubt, or fixes aren't being sent upstream.
It is the broad consent among the users of the drbd-8.4 branch (that is what
is in-tree), is that it works for its purpose. It is for sure not bug-free,
but people are not running into bugs anymore. So, call it free of relevant
bugs, if you want. No new features go into that branch, on purpose. To keep
it that way.
Have a look at that one real bug-fix that was identified in the last Year.
20210426163032.3454129-1-christoph.boehmwalder@linbit.com <https://patchwork.kernel.org/project/linux-block/patch/<a href=>/">https://patchwork.kernel.org/project/linux-block/patch/20210426163032.3454129-1-christoph.boehmwalder@linbit.com/
When do you want to have that reposted to you?
right now? Just before the next merge window opens?
_______________________________________________
drbd-dev mailing list
drbd-dev@lists.linbit.com
https://lists.linbit.com/mailman/listinfo/drbd-dev
next prev parent reply other threads:[~2022-03-30 19:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 7:06 [Drbd-dev] state of drbd in mainline Christoph Hellwig
2022-03-29 7:22 ` Philipp Reisner
2022-03-29 7:32 ` Christoph Hellwig
2022-03-29 7:50 ` Philipp Reisner
2022-03-29 12:29 ` Jens Axboe
2022-03-29 15:44 ` Philipp Reisner
2022-03-29 15:52 ` Jens Axboe
2022-03-30 15:23 ` Philipp Reisner
2022-03-30 18:06 ` Mike Snitzer
2022-03-30 18:24 ` Jens Axboe
2022-03-30 19:31 ` Kiselev, Oleg [this message]
2022-03-30 20:21 ` Jens Axboe
2022-03-29 20:01 ` Wolfgang Walter
2022-03-29 7:24 ` Philipp Reisner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7AD2D6DC-0609-42F9-A481-B6E5C0F58180@amazon.com \
--to=okiselev@amazon.com \
--cc=axboe@kernel.dk \
--cc=benh@amazon.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@lst.de \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=trawets@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox