From: Markus Elfring <Markus.Elfring@web.de>
To: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>,
kernel-janitors@vger.kernel.org, drbd-dev@lists.linbit.com,
linux-block@vger.kernel.org, "Jens Axboe" <axboe@kernel.dk>,
"Lars Ellenberg" <lars.ellenberg@linbit.com>,
"Philipp Reisner" <philipp.reisner@linbit.com>
Cc: LKML <linux-kernel@vger.kernel.org>, cocci@inria.fr
Subject: Re: [Drbd-dev] drbd: Fix exception handling in nla_put_drbd_cfg_context()
Date: Mon, 27 Mar 2023 19:26:22 +0200 [thread overview]
Message-ID: <7a6c195f-42df-eef2-e2b7-9f7510dbdf06@web.de> (raw)
In-Reply-To: <a989f01e-79a9-44a4-3603-ba4eeeb86dea@linbit.com>
> Can you identify the issue with the current code and can you explain how
> your patch makes it better?
I propose to avoid a duplicate pointer check also in this function implementation.
Regards,
Markus
prev parent reply other threads:[~2023-03-27 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f9303bdc-b1a7-be5e-56c6-dfa8232b8b55@web.de>
2023-03-17 17:40 ` [Drbd-dev] [PATCH] drbd: Fix exception handling in nla_put_drbd_cfg_context() Markus Elfring
2023-03-25 14:07 ` [Drbd-dev] [PATCH resent] " Markus Elfring
2023-03-27 12:28 ` Christoph Böhmwalder
2023-03-27 17:26 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a6c195f-42df-eef2-e2b7-9f7510dbdf06@web.de \
--to=markus.elfring@web.de \
--cc=axboe@kernel.dk \
--cc=christoph.boehmwalder@linbit.com \
--cc=cocci@inria.fr \
--cc=drbd-dev@lists.linbit.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox