Re: [Drbd-dev] [PATCH v3 1/2] drbd: remove call to memset before free device/resource/connection

["Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>]

Am 23.11.22 um 03:03 schrieb Wang ShaoBo:
> This revert c2258ffc56f2 ("drbd: poison free'd device, resource and
> connection structs"), add memset is odd here for debugging, there are
> some methods to accurately show what happened, such as kdump.
> 
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
> ---
>  drivers/block/drbd/drbd_main.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
> index 8532b839a343..78cae4e75af1 100644
> --- a/drivers/block/drbd/drbd_main.c
> +++ b/drivers/block/drbd/drbd_main.c
> @@ -2217,7 +2217,6 @@ void drbd_destroy_device(struct kref *kref)
>  		kref_put(&peer_device->connection->kref, drbd_destroy_connection);
>  		kfree(peer_device);
>  	}
> -	memset(device, 0xfd, sizeof(*device));
>  	kfree(device);
>  	kref_put(&resource->kref, drbd_destroy_resource);
>  }
> @@ -2309,7 +2308,6 @@ void drbd_destroy_resource(struct kref *kref)
>  	idr_destroy(&resource->devices);
>  	free_cpumask_var(resource->cpu_mask);
>  	kfree(resource->name);
> -	memset(resource, 0xf2, sizeof(*resource));
>  	kfree(resource);
>  }
>  
> @@ -2650,7 +2648,6 @@ void drbd_destroy_connection(struct kref *kref)
>  	drbd_free_socket(&connection->data);
>  	kfree(connection->int_dig_in);
>  	kfree(connection->int_dig_vv);
> -	memset(connection, 0xfc, sizeof(*connection));
>  	kfree(connection);
>  	kref_put(&resource->kref, drbd_destroy_resource);
>  }

Thanks!

Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>

-- 
Christoph Böhmwalder
LINBIT | Keeping the Digital World Running
DRBD HA —  Disaster Recovery — Software defined Storage