From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 52D2F420960 for ; Fri, 28 Oct 2022 16:11:31 +0200 (CEST) Received: by mail-io1-f46.google.com with SMTP id h206so1156258iof.10 for ; Fri, 28 Oct 2022 07:11:31 -0700 (PDT) Message-ID: <9bb423f8-5910-494d-2522-2fcf8e41c2e4@kernel.dk> Date: Fri, 28 Oct 2022 08:11:27 -0600 MIME-Version: 1.0 Content-Language: en-US To: Steven Rostedt References: <20221027150525.753064657@goodmis.org> <20221027150925.819019339@goodmis.org> <20221027111944.39b3a80c@gandalf.local.home> <20221028062414.7859f787@gandalf.local.home> <60b91c39-1e54-ac8b-5e9e-db7e46ca2d60@kernel.dk> <20221028100656.00a4d537@gandalf.local.home> From: Jens Axboe In-Reply-To: <20221028100656.00a4d537@gandalf.local.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: linux-block@vger.kernel.org, Stephen Boyd , linux-kernel@vger.kernel.org, Philipp Reisner , Christoph Hellwig , Tejun Heo , cgroups@vger.kernel.org, Thomas Gleixner , Linus Torvalds , Lars Ellenberg , Guenter Roeck , drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [RFC][PATCH v2 04/31] timers: block: Use del_timer_shutdown() before freeing timer List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 10/28/22 8:06 AM, Steven Rostedt wrote: > On Fri, 28 Oct 2022 07:56:50 -0600 > Jens Axboe wrote: > >> On 10/28/22 4:24 AM, Steven Rostedt wrote: >>> On Fri, 28 Oct 2022 01:26:03 -0700 >>> Christoph Hellwig wrote: >>> >>>> This is just a single patch out of apparently 31, which claims that >>>> something that doesn't even exist in mainline must be used without any >>>> explanation. How do you expect anyone to be able to review it? >>> >>> https://lore.kernel.org/all/20221027150525.753064657@goodmis.org/ >>> >>> Only the first patch is relevant to you. I guess the Cc list would have >>> been too big to Cc everyone that was Cc'd in the series. >> >> No it's not, because how on earth would anyone know what the change does >> if you only see the simple s/name/newname change? The patch is useless >> by itself. >> > > I meant this as the first patch: > > https://lore.kernel.org/all/20221027150925.248421571@goodmis.org/ > > Which was what the link above was suppose to point to. > > It's the only patch relevant to the rest of the series, as the rest is just > converting over to the shutdown API, and the last patch changes > DEBUG_OBJECTS_TIMERS to catch if this was done properly. > > That is, patch 01/31 and the patch you were Cc'd on is relevant, and for > those that want to look deeper, see patch 31 as well. So we got half of what was needed to make any kind of sense of judgement on the patch. > But if I included the Cc list for patch 01 for all those Cc'd in the > entire series, it would be a huge Cc list, so I avoided doing so. And my point is that just CC'ing the relevant list for patch 4/31 is useless. Do we need to see the whole series? No. Does everyone need to see patch 1/31? Yes, very much so. Without that, 4/31 means nothing. This is pretty common for tree wide changes. The relevant lists need to see the full context, patch 4/31 by itself is useless and may as well not be sent at this point then. -- Jens Axboe