From: Su Yue <glass.su@suse.com>
To: drbd-dev@lists.linbit.com
Cc: lars.ellenberg@linbit.com
Subject: Re: [PATCH 2/2] crm-fence-peer.9.sh: use join of node_state to judge whether node is banned
Date: Thu, 7 Mar 2024 10:54:29 +0800 [thread overview]
Message-ID: <C2F581E6-5D15-49E7-B944-B79B3C08F252@suse.com> (raw)
In-Reply-To: <20240303091259.5045-2-l@damenly.org>
Hi, dear drbd folks
Would you help review the patches for drbd-utils? Many thanks!
—
Su
> On Mar 3, 2024, at 17:12, Su Yue <glass.su@suse.com> wrote:
>
> From: Su Yue <glass.su@suse.com>
>
> crmd in node_state can't be "banned". join should be used instead
> of crmd.
>
> Signed-off-by: Su Yue <glass.su@suse.com>
> ---
> scripts/crm-fence-peer.9.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/crm-fence-peer.9.sh b/scripts/crm-fence-peer.9.sh
> index a3353a7354a6..b326a1656c15 100755
> --- a/scripts/crm-fence-peer.9.sh
> +++ b/scripts/crm-fence-peer.9.sh
> @@ -934,7 +934,7 @@ guess_if_pacemaker_will_fence()
>
> # for further inspiration, see pacemaker:lib/pengine/unpack.c, determine_online_status_fencing()
> [[ -z $in_ccm ]] && will_fence=true
> - [[ $crmd = "banned" ]] && will_fence=true
> + [[ $join = "banned" ]] && will_fence=true
> if [[ ${expected-down} = "down" && $in_ccm = "false" && $crmd != "online" ]]; then
> : "pacemaker considers this as clean down"
> elif [[ $in_ccm = false ]] || [[ $crmd != "online" ]]; then
> --
> 2.44.0
>
next prev parent reply other threads:[~2024-03-07 2:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 9:12 [PATCH 1/2] crm-fence-peer.9.sh: fix parsing in_ccm crmd fields of node_state with Pacemaker 2.1.7 Su Yue
2024-03-03 9:12 ` [PATCH 2/2] crm-fence-peer.9.sh: use join of node_state to judge whether node is banned Su Yue
2024-03-07 2:54 ` Su Yue [this message]
2024-03-14 3:18 ` Su Yue
2024-04-17 9:57 ` Lars Ellenberg
2024-04-17 10:47 ` Glass Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C2F581E6-5D15-49E7-B944-B79B3C08F252@suse.com \
--to=glass.su@suse.com \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox