From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 4BDC14252D7 for ; Tue, 22 Nov 2022 15:23:47 +0100 (CET) From: Benjamin Coddington To: Shuah Khan Date: Tue, 22 Nov 2022 09:23:29 -0500 Message-ID: In-Reply-To: <96114bec-1df7-0dcb-ec99-4f907587658d@linuxfoundation.org> References: <382872.1669039019@warthog.procyon.org.uk> <51B5418D-34FB-4E87-B87A-6C3FCDF8B21C@redhat.com> <4585e331-03ad-959f-e715-29af15f63712@linuxfoundation.org> <26d98c8f-372b-b9c8-c29f-096cddaff149@linuxfoundation.org> <96114bec-1df7-0dcb-ec99-4f907587658d@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Cc: Latchesar Ionkov , samba-technical@lists.samba.org, Dominique Martinet , Valentina Manea , linux-nvme@lists.infradead.org, Philipp Reisner , David Howells , Joseph Qi , Eric Dumazet , linux-nfs@vger.kernel.org, Marc Dionne , Shuah Khan , Christoph Hellwig , Mike Christie , drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org, Sagi Grimberg , linux-scsi@vger.kernel.org, Mark Fasheh , linux-afs@lists.infradead.org, cluster-devel@redhat.com, Christine Caulfield , Jakub Kicinski , Ilya Dryomov , Paolo Abeni , Anna Schumaker , Eric Van Hensbergen , "James E.J. Bottomley" , Josef Bacik , nbd@other.debian.org, linux-block@vger.kernel.org, David Teigland , Joel Becker , v9fs-developer@lists.sourceforge.net, Keith Busch , ceph-devel@vger.kernel.org, Xiubo Li , Trond Myklebust , Jens Axboe , Chris Leech , open-iscsi@googlegroups.com, "Martin K. Petersen" , netdev@vger.kernel.org, linux-usb@vger.kernel.org, Jeff Layton , linux-kernel@vger.kernel.org, Steve French , Chuck Lever , Lee Duncan , Greg Kroah-Hartman , Lars Ellenberg , "David S. Miller" , ocfs2-devel@oss.oracle.com Subject: Re: [Drbd-dev] [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 21 Nov 2022, at 17:32, Shuah Khan wrote: > On 11/21/22 15:01, Benjamin Coddington wrote: >> On 21 Nov 2022, at 16:43, Shuah Khan wrote: >> >>> On 11/21/22 14:40, Shuah Khan wrote: >>>> On 11/21/22 07:34, Benjamin Coddington wrote: >>>>> On 21 Nov 2022, at 8:56, David Howells wrote: >>>>> >>>>>> Benjamin Coddington wrote: >>>>>> >>>>>>> Since moving to memalloc_nofs_save/restore, SUNRPC has stopped se= tting the >>>>>>> GFP_NOIO flag on sk_allocation which the networking system uses t= o decide >>>>>>> when it is safe to use current->task_frag. >>>>>> >>>>>> Um, what's task_frag? >>>>> >>>>> Its a per-task page_frag used to coalesce small writes for networki= ng -- see: >>>>> >>>>> 5640f7685831 net: use a per task frag allocator >>>>> >>>>> Ben >>>>> >>>>> >>>> >>>> I am not seeing this in the mainline. Where can find this commit? >>>> >>> >>> Okay. I see this commit in the mainline. However, I don't see the >>> sk_use_task_frag in mainline. >> >> sk_use_task_frag is in patch 1/3 in this posting. >> >> https://lore.kernel.org/netdev/26d98c8f-372b-b9c8-c29f-096cddaff149@li= nuxfoundation.org/T/#m3271959c4cf8dcff1c0c6ba023b2b3821d9e7e99 >> > > Aha. I don't have 1/3 in my Inbox - I think it would make > sense to cc people on the first patch so we can understand > the premise for the change. Yeah, I can do that if it goes to another version, I was just trying to b= e considerate of all the noise this sort of posting generates. Ben