From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id A7AFB4202E5 for ; Fri, 21 Apr 2023 22:37:22 +0200 (CEST) Date: Fri, 21 Apr 2023 21:15:15 +0100 From: Matthew Wilcox To: Luis Chamberlain Message-ID: References: <20230421195807.2804512-1-mcgrof@kernel.org> <20230421195807.2804512-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230421195807.2804512-2-mcgrof@kernel.org> Cc: djwong@kernel.org, philipp.reisner@linbit.com, linux-mm@kvack.org, dm-devel@redhat.com, agk@redhat.com, drbd-dev@lists.linbit.com, hch@infradead.org, p.raghav@samsung.com, senozhatsky@chromium.org, snitzer@kernel.org, linux-block@vger.kernel.org, hare@suse.de, kbusch@kernel.org, axboe@kernel.dk, da.gomez@samsung.com, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, minchan@kernel.org, patches@lists.linux.dev, linux-fsdevel@vger.kernel.org, lars.ellenberg@linbit.com Subject: Re: [Drbd-dev] [PATCH 1/5] dm integrity: simplify by using PAGE_SECTORS_SHIFT List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Apr 21, 2023 at 12:58:03PM -0700, Luis Chamberlain wrote: > - *pl_index = sector >> (PAGE_SHIFT - SECTOR_SHIFT); > + *pl_index = sector >> (PAGE_SECTORS_SHIFT); You could/should remove the () around PAGE_SECTORS_SHIFT (throughout)