From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 176D34203AB for ; Wed, 3 May 2023 06:20:16 +0200 (CEST) Date: Tue, 2 May 2023 21:18:01 -0700 From: Christoph Hellwig To: Christoph =?iso-8859-1?Q?B=F6hmwalder?= Message-ID: References: <20230502092922.175857-1-christoph.boehmwalder@linbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230502092922.175857-1-christoph.boehmwalder@linbit.com> Cc: Jens Axboe , Thomas Voegtle , Philipp Reisner , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Lars Ellenberg , drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [PATCH] drbd: do not set REQ_PREFLUSH when submitting barrier List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, May 02, 2023 at 11:29:22AM +0200, Christoph Böhmwalder wrote: > struct bio *bio = bio_alloc(device->ldev->backing_bdev, 0, > - REQ_OP_FLUSH | REQ_PREFLUSH, GFP_NOIO); > + REQ_OP_FLUSH, GFP_NOIO); This isn't going to work. flush bios are (somewhat confusingly) implemented as writes with no data and the preflush flag. So this should be: REQ_OP_WRITE | REQ_PREFLUSH. and it looks like whatever flushing this does hasn't wroked for a long time.