From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id DFFD54252E9 for ; Fri, 26 May 2023 10:15:39 +0200 (CEST) Date: Fri, 26 May 2023 01:13:14 -0700 From: Christoph Hellwig To: Luis Chamberlain Message-ID: References: <20230526073336.344543-1-mcgrof@kernel.org> <20230526073336.344543-2-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230526073336.344543-2-mcgrof@kernel.org> Cc: djwong@kernel.org, philipp.reisner@linbit.com, linux-mm@kvack.org, dm-devel@redhat.com, agk@redhat.com, drbd-dev@lists.linbit.com, willy@infradead.org, hch@infradead.org, p.raghav@samsung.com, rohan.puri@samsung.com, senozhatsky@chromium.org, snitzer@kernel.org, linux-block@vger.kernel.org, hare@suse.de, kbusch@kernel.org, axboe@kernel.dk, da.gomez@samsung.com, linux-kernel@vger.kernel.org, rpuri.linux@gmail.com, linux-xfs@vger.kernel.org, minchan@kernel.org, patches@lists.linux.dev, linux-fsdevel@vger.kernel.org, lars.ellenberg@linbit.com Subject: Re: [Drbd-dev] [PATCH v2 1/5] block: annotate bdev_disk_changed() deprecation with a symbol namespace List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, May 26, 2023 at 12:33:32AM -0700, Luis Chamberlain wrote: > This ensures no other users pop up by mistake easily and provides > us a with an easy vehicle to do the same with other routines should > we need it later. I don't see how this is related to the rest of the seris. I also don't think it's a good idea. The APIs isn't deprecated per se. It just should not be called by drivers. The right thing would be an interface like EXPORT_SYMBOL_GPL_FOR(bdev_disk_changed, loop.ko, CONFIG_BLK_DEV_LOOP); EXPORT_SYMBOL_GPL_FOR(bdev_disk_changed, dasd_mod.ko, CONFIG_DASD); with the modulo code enforcing that no one but the module this is explicitly exorted for can use the symbol.