From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id EC08F16095C for ; Thu, 5 Mar 2026 15:12:53 +0100 (CET) Date: Thu, 5 Mar 2026 06:12:49 -0800 From: Christoph Hellwig To: Andreas Gruenbacher Subject: Re: [PATCH 1/4] block: consecutive blk_status_t error codes Message-ID: References: <20260304190424.291743-1-agruenba@redhat.com> <20260304190424.291743-2-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260304190424.291743-2-agruenba@redhat.com> Cc: Jens Axboe , dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, drbd-dev@lists.linbit.com List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Mar 04, 2026 at 08:04:06PM +0100, Andreas Gruenbacher wrote: > Since commit 9da3d1e912f3 ("block: Add core atomic write support"), > there is a gap in the blk_status_t codes and block status code 18 is > unused. This causes blk_status_to_errno() and blk_status_to_str() to > return incorrect values for that code. Make the blk_status_t codes > consecutive again to avoid that. Looks good: Reviewed-by: Christoph Hellwig