From: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>, Thomas Voegtle <tv@lio96.de>,
Philipp Reisner <philipp.reisner@linbit.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>,
drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] drbd: do not set REQ_PREFLUSH when submitting barrier
Date: Wed, 3 May 2023 13:05:57 +0200 [thread overview]
Message-ID: <b1568ca5-4daf-f6b5-7861-4881aa46e578@linbit.com> (raw)
In-Reply-To: <ZFHgefWofVt24tRl@infradead.org>
Am 03.05.23 um 06:18 schrieb Christoph Hellwig:
> On Tue, May 02, 2023 at 11:29:22AM +0200, Christoph Böhmwalder wrote:
>> struct bio *bio = bio_alloc(device->ldev->backing_bdev, 0,
>> - REQ_OP_FLUSH | REQ_PREFLUSH, GFP_NOIO);
>> + REQ_OP_FLUSH, GFP_NOIO);
>
> This isn't going to work. flush bios are (somewhat confusingly)
Indeed...
> implemented as writes with no data and the preflush flag. So this
> should be:
>
> REQ_OP_WRITE | REQ_PREFLUSH.
>
> and it looks like whatever flushing this does hasn't wroked for a long
> time.
Thanks for the hint. I'll prepare a v2 today.
--
Christoph Böhmwalder
LINBIT | Keeping the Digital World Running
DRBD HA — Disaster Recovery — Software defined Storage
prev parent reply other threads:[~2023-05-03 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 9:29 [Drbd-dev] [PATCH] drbd: do not set REQ_PREFLUSH when submitting barrier Christoph Böhmwalder
2023-05-03 4:18 ` Christoph Hellwig
2023-05-03 11:05 ` Christoph Böhmwalder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1568ca5-4daf-f6b5-7861-4881aa46e578@linbit.com \
--to=christoph.boehmwalder@linbit.com \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@infradead.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
--cc=tv@lio96.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox