From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id B9BE0160996 for ; Wed, 28 May 2025 12:08:44 +0200 (CEST) Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-3a4db4d1bd7so466902f8f.3 for ; Wed, 28 May 2025 03:08:44 -0700 (PDT) Received: from [10.202.112.30] ([202.127.77.110]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b2d99e1e78asm837158a12.30.2025.05.28.03.08.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 May 2025 03:08:42 -0700 (PDT) Message-ID: Date: Wed, 28 May 2025 18:08:39 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v2 1/2] build: changing SUSE release file To: drbd-dev@lists.linbit.com References: <20250515024817.25717-1-heming.zhao@suse.com> <20250515024817.25717-2-heming.zhao@suse.com> From: Heming Zhao Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 5/28/25 16:03, Roland Kammerer wrote: > On Thu, May 15, 2025 at 10:48:14AM +0800, Heming Zhao wrote: >> This commit changes /etc/SuSe-release to /etc/os-release. >> The SuSe-release file disappeared a long time ago. >> >> Signed-off-by: Heming Zhao >> --- >> configure.ac | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/configure.ac b/configure.ac >> index 282fdf1584e3..883fe3e5cdb3 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -402,7 +402,7 @@ else >> if test -z $DISTRO; then >> AC_CHECK_FILE(/etc/redhat-release, [DISTRO="redhat"]) >> AC_CHECK_FILE(/etc/debian_version, [DISTRO="debian"]) >> - AC_CHECK_FILE(/etc/SuSE-release, [DISTRO="suse"]) >> + AC_CHECK_FILE(/etc/os-release, [DISTRO="suse"]) > > Hi, > > everything that has a /etc/os-release (which by now is basically every > distribution on this planet) is suse? No. > > This (not only this) part of the automagic in drbd-utils is a mess and > I'm currently in the process of cleaning that up a bit. I will not take > this patch as is, IMO it is just wrong, please just wait, this should > improve in a week or two. > > Regards, rck Thanks for the explanation. Indeed, I didn't check other distribution styles. Let's wait for your fix for this build issue. - Heming