From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id A75164202C2 for ; Wed, 19 Jun 2024 16:21:19 +0200 (CEST) Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-7119502613bso87125a12.2 for ; Wed, 19 Jun 2024 07:21:19 -0700 (PDT) Message-ID: Date: Wed, 19 Jun 2024 08:21:14 -0600 MIME-Version: 1.0 Subject: Re: move features flags into queue_limits v2 From: Jens Axboe To: Christoph Hellwig References: <20240617060532.127975-1-hch@lst.de> <171880672048.115609.5962725096227627176.b4-ty@kernel.dk> Content-Language: en-US In-Reply-To: <171880672048.115609.5962725096227627176.b4-ty@kernel.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: nvdimm@lists.linux.dev, "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , linux-mtd@lists.infradead.org, Vineeth Vijayan , Alasdair Kergon , drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Richard Weinberger , Geert Uytterhoeven , Yu Kuai , dm-devel@lists.linux.dev, linux-um@lists.infradead.org, Mike Snitzer , Josef Bacik , nbd@other.debian.org, linux-raid@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Mikulas Patocka , xen-devel@lists.xenproject.org, ceph-devel@vger.kernel.org, Ming Lei , linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, "Martin K. Petersen" , linux-mmc@vger.kernel.org, Philipp Reisner , virtualization@lists.linux.dev, Lars Ellenberg , linuxppc-dev@lists.ozlabs.org, =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 6/19/24 8:18 AM, Jens Axboe wrote: > > On Mon, 17 Jun 2024 08:04:27 +0200, Christoph Hellwig wrote: >> this is the third and last major series to convert settings to >> queue_limits for this merge window. After a bunch of prep patches to >> get various drivers in shape, it moves all the queue_flags that specify >> driver controlled features into the queue limits so that they can be >> set atomically and are separated from the blk-mq internal flags. >> >> Note that I've only Cc'ed the maintainers for drivers with non-mechanical >> changes as the Cc list is already huge. >> >> [...] > > Applied, thanks! Please check for-6.11/block, as I pulled in the changes to the main block branch and that threw some merge conflicts mostly due to Damien's changes in for-6.11/block. While fixing those up, I also came across oddities like: (limits->features & limits->features & BLK_FEAT_ZONED)) { which don't make much sense and hence I changed them to (limits->features & BLK_FEAT_ZONED)) { -- Jens Axboe