From: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: axboe@kernel.dk, lars.ellenberg@linbit.com,
philipp.reisner@linbit.com, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] block/drbd: remove unused w_start_resync declaration
Date: Mon, 12 Sep 2022 09:36:51 +0200 [thread overview]
Message-ID: <eabdb4f6-c58e-dcb9-b886-7e244754c461@linbit.com> (raw)
In-Reply-To: <20220911092645.3218009-1-cuigaosheng1@huawei.com>
Am 11.09.22 um 11:26 schrieb Gaosheng Cui:
> w_start_resync has been removed since
> commit ac0acb9e39ac ("drbd: use drbd_device_post_work()
> in more places"), so remove it.
>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
> drivers/block/drbd/drbd_int.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
> index f15f2f041596..4d661282ff41 100644
> --- a/drivers/block/drbd/drbd_int.h
> +++ b/drivers/block/drbd/drbd_int.h
> @@ -1529,7 +1529,6 @@ extern int w_send_read_req(struct drbd_work *, int);
> extern int w_e_reissue(struct drbd_work *, int);
> extern int w_restart_disk_io(struct drbd_work *, int);
> extern int w_send_out_of_sync(struct drbd_work *, int);
> -extern int w_start_resync(struct drbd_work *, int);
>
> extern void resync_timer_fn(struct timer_list *t);
> extern void start_resync_timer_fn(struct timer_list *t);
Thanks for the patch, looks good to me.
Acked-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
--
Christoph Böhmwalder
LINBIT | Keeping the Digital World Running
DRBD HA — Disaster Recovery — Software defined Storage
next prev parent reply other threads:[~2022-09-12 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 9:26 [Drbd-dev] [PATCH] block/drbd: remove unused w_start_resync declaration Gaosheng Cui
2022-09-12 7:36 ` Christoph Böhmwalder [this message]
2022-09-12 7:48 ` Jens Axboe
2022-09-12 7:59 ` cuigaosheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eabdb4f6-c58e-dcb9-b886-7e244754c461@linbit.com \
--to=christoph.boehmwalder@linbit.com \
--cc=axboe@kernel.dk \
--cc=cuigaosheng1@huawei.com \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox