From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 4B61142018E for ; Tue, 15 Aug 2023 14:56:07 +0200 (CEST) From: Aaron Conole To: Jakub Kicinski References: <20230814214723.2924989-1-kuba@kernel.org> <20230814214723.2924989-4-kuba@kernel.org> Date: Tue, 15 Aug 2023 08:49:08 -0400 In-Reply-To: <20230814214723.2924989-4-kuba@kernel.org> (Jakub Kicinski's message of "Mon, 14 Aug 2023 14:47:16 -0700") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Cc: axboe@kernel.dk, dev@openvswitch.org, jiri@resnulli.us, netdev@vger.kernel.org, jacob.e.keller@intel.com, philipp.reisner@linbit.com, jmaloy@redhat.com, linux-block@vger.kernel.org, edumazet@google.com, tipc-discussion@lists.sourceforge.net, lars.ellenberg@linbit.com, Jiri Pirko , ying.xue@windriver.com, johannes@sipsolutions.net, pabeni@redhat.com, davem@davemloft.net, drbd-dev@lists.linbit.com Subject: Re: [Drbd-dev] [ovs-dev] [PATCH net-next v3 03/10] genetlink: remove userhdr from struct genl_info List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Jakub Kicinski writes: > Only three families use info->userhdr today and going forward > we discourage using fixed headers in new families. > So having the pointer to user header in struct genl_info > is an overkill. Compute the header pointer at runtime. > > Reviewed-by: Johannes Berg > Reviewed-by: Jiri Pirko > Signed-off-by: Jakub Kicinski > --- Seems the OVS side didn't change from v2 so still: Reviewed-by: Aaron Conole