Distributed Replicated Block Device (DRBD) development
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: axboe@kernel.dk, linux-raid@vger.kernel.org,
	martin.petersen@oracle.com, snitzer@redhat.com,
	philipp.reisner@linbit.com, linux-block@vger.kernel.org,
	dm-devel@redhat.com, linux-scsi@vger.kernel.org,
	lars.ellenberg@linbit.com, shli@kernel.org,
	Christoph Hellwig <hch@lst.de>,
	agk@redhat.com, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH 26/27] scsi: sd: Separate zeroout and discard command choices
Date: Wed, 19 Apr 2017 21:34:18 -0400	[thread overview]
Message-ID: <yq1a87bsvz9.fsf@oracle.com> (raw)
In-Reply-To: <58c3d6a6-924e-cc86-1907-a9fd02a39c0e@redhat.com> (Paolo Bonzini's message of "Wed, 19 Apr 2017 16:56:31 +0200")


Paolo,

> Should this be conditional on lbprz, lbpws, lbpws10 and max_ws_blocks?

It is intentional that things can be overridden from userland for
devices that report the "wrong" thing. We do the same for discard so
people can set up udev rules.

-- 
Martin K. Petersen	Oracle Linux Engineering

  parent reply	other threads:[~2017-04-20  1:34 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 17:20 [Drbd-dev] always use REQ_OP_WRITE_ZEROES for zeroing offload V2 Christoph Hellwig
2017-04-05 17:20 ` [Drbd-dev] [PATCH 01/27] sd: split sd_setup_discard_cmnd Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 02/27] block: renumber REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 03/27] block: implement splitting of REQ_OP_WRITE_ZEROES bios Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 04/27] sd: implement REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 05/27] md: support REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 06/27] dm io: discards don't take a payload Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 08/27] dm kcopyd: switch to use REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 09/27] block: stop using blkdev_issue_write_same for zeroing Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 10/27] block: add a flags argument to (__)blkdev_issue_zeroout Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 11/27] block: add a REQ_NOUNMAP flag for REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 12/27] block: add a new BLKDEV_ZERO_NOFALLBACK flag Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 13/27] block_dev: use blkdev_issue_zerout for hole punches Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 14/27] sd: implement unmapping Write Zeroes Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 15/27] nvme: implement REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 16/27] zram: " Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 17/27] loop: " Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 18/27] brd: remove discard support Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 19/27] rbd: remove the discard_zeroes_data flag Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 20/27] rsxx: " Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 21/27] mmc: " Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 22/27] block: stop using discards for zeroing Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 23/27] drbd: make intelligent use of blkdev_issue_zeroout Christoph Hellwig
2018-01-13  0:46   ` Eric Wheeler
2018-01-15 12:46     ` Lars Ellenberg
2018-01-15 15:07       ` Mike Snitzer
2018-01-16  8:55         ` Lars Ellenberg
2017-04-05 17:21 ` [Drbd-dev] [PATCH 24/27] drbd: implement REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-04-05 17:21 ` [Drbd-dev] [PATCH 25/27] block: remove the discard_zeroes_data flag Christoph Hellwig
2017-05-01 20:45   ` Bart Van Assche
2017-05-02  6:43     ` Nicholas A. Bellinger
2017-05-02  7:16       ` Nicholas A. Bellinger
2017-05-02  7:23         ` hch
2017-05-03  3:33           ` Nicholas A. Bellinger
2017-05-03 14:33             ` Mike Snitzer
2017-05-05  3:10               ` Nicholas A. Bellinger
2017-05-07  9:22             ` hch
2017-05-09  6:46               ` Nicholas A. Bellinger
2017-05-10 14:06                 ` hch
2017-05-11  4:50                   ` Nicholas A. Bellinger
2017-05-11  6:26                     ` hch
2017-05-11  6:36                       ` Nicholas A. Bellinger
2017-04-05 17:21 ` [Drbd-dev] [PATCH 26/27] scsi: sd: Separate zeroout and discard command choices Christoph Hellwig
     [not found]   ` <58c3d6a6-924e-cc86-1907-a9fd02a39c0e@redhat.com>
2017-04-20  1:34     ` Martin K. Petersen [this message]
2017-04-05 17:21 ` [Drbd-dev] [PATCH 27/27] scsi: sd: Remove LBPRZ dependency for discards Christoph Hellwig
2017-04-08 17:26 ` [Drbd-dev] always use REQ_OP_WRITE_ZEROES for zeroing offload V2 Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1a87bsvz9.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=hch@lst.de \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=philipp.reisner@linbit.com \
    --cc=shli@kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox