From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: RE: [PATCH 1/5] drm/exynos: Remove redundant check in exynos_hdmi.c file Date: Wed, 08 Aug 2012 10:05:52 +0900 Message-ID: <002301cd7501$f4afc730$de0f5590$%dae@samsung.com> References: <1344235580-3030-1-git-send-email-sachin.kamat@linaro.org> <1344235580-3030-2-git-send-email-sachin.kamat@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id AAD309E7E4 for ; Tue, 7 Aug 2012 18:05:19 -0700 (PDT) Received: from epcpsbgm1.samsung.com (mailout1.samsung.com [203.254.224.24]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M8E00H3AWC98N80@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 08 Aug 2012 10:05:18 +0900 (KST) Received: from NOINKIDAE02 ([10.90.51.52]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M8E0024BWCTDE00@mmp1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 08 Aug 2012 10:05:18 +0900 (KST) In-reply-to: <1344235580-3030-2-git-send-email-sachin.kamat@linaro.org> Content-language: ko List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: 'Sachin Kamat' , dri-devel@lists.freedesktop.org Cc: patches@linaro.org List-Id: dri-devel@lists.freedesktop.org > -----Original Message----- > From: Sachin Kamat [mailto:sachin.kamat@linaro.org] > Sent: Monday, August 06, 2012 3:46 PM > To: dri-devel@lists.freedesktop.org > Cc: inki.dae@samsung.com; airlied@linux.ie; sachin.kamat@linaro.org; > patches@linaro.org > Subject: [PATCH 1/5] drm/exynos: Remove redundant check in exynos_hdmi.c > file > > devm_request_and_ioremap function checks the validity of the > pointer returned by platform_get_resource. Hence an additional check > in the probe function is not necessary. > > Signed-off-by: Sachin Kamat > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c > b/drivers/gpu/drm/exynos/exynos_hdmi.c > index 409e2ec..bb504cb 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > @@ -2312,11 +2312,6 @@ static int __devinit hdmi_probe(struct > platform_device *pdev) > } > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - DRM_ERROR("failed to find registers\n"); > - ret = -ENOENT; > - goto err_resource; > - } > > hdata->regs = devm_request_and_ioremap(&pdev->dev, res); > if (!hdata->regs) { > -- > 1.7.4.1 Applied. Thanks for your patch.