From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: RE: [PATCH 3/5] drm/exynos: Use devm_kzalloc in exynos_drm_vidi.c file Date: Wed, 08 Aug 2012 10:08:53 +0900 Message-ID: <002501cd7502$60b76af0$222640d0$%dae@samsung.com> References: <1344235580-3030-1-git-send-email-sachin.kamat@linaro.org> <1344235580-3030-4-git-send-email-sachin.kamat@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id 51FE49E7E4 for ; Tue, 7 Aug 2012 18:08:20 -0700 (PDT) Received: from epcpsbgm2.samsung.com (mailout4.samsung.com [203.254.224.34]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M8E002R1WH2HY60@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 08 Aug 2012 10:08:19 +0900 (KST) Received: from NOINKIDAE02 ([10.90.51.52]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M8E008P3WHV7Y90@mmp2.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 08 Aug 2012 10:08:19 +0900 (KST) In-reply-to: <1344235580-3030-4-git-send-email-sachin.kamat@linaro.org> Content-language: ko List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: 'Sachin Kamat' , dri-devel@lists.freedesktop.org Cc: patches@linaro.org List-Id: dri-devel@lists.freedesktop.org > -----Original Message----- > From: Sachin Kamat [mailto:sachin.kamat@linaro.org] > Sent: Monday, August 06, 2012 3:46 PM > To: dri-devel@lists.freedesktop.org > Cc: inki.dae@samsung.com; airlied@linux.ie; sachin.kamat@linaro.org; > patches@linaro.org > Subject: [PATCH 3/5] drm/exynos: Use devm_kzalloc in exynos_drm_vidi.c > file > > devm_kzalloc is a device managed function and makes freeing and error > handling simpler. > > Signed-off-by: Sachin Kamat > --- > drivers/gpu/drm/exynos/exynos_drm_vidi.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c > b/drivers/gpu/drm/exynos/exynos_drm_vidi.c > index bb1550c..537027a 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_vidi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_vidi.c > @@ -633,7 +633,7 @@ static int __devinit vidi_probe(struct platform_device > *pdev) > > DRM_DEBUG_KMS("%s\n", __FILE__); > > - ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); > + ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL); > if (!ctx) > return -ENOMEM; > > @@ -673,8 +673,6 @@ static int __devexit vidi_remove(struct > platform_device *pdev) > ctx->raw_edid = NULL; > } > > - kfree(ctx); > - > return 0; > } > > -- > 1.7.4.1 Applied. Thanks for your patch.