From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: RE: [PATCH 4/5] drm/exynos: Use devm_kzalloc in exynos_drm_hdmi.c file Date: Wed, 08 Aug 2012 10:09:33 +0900 Message-ID: <002601cd7502$78748920$695d9b60$%dae@samsung.com> References: <1344235580-3030-1-git-send-email-sachin.kamat@linaro.org> <1344235580-3030-5-git-send-email-sachin.kamat@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id 034C69ECB6 for ; Tue, 7 Aug 2012 18:08:59 -0700 (PDT) Received: from epcpsbgm1.samsung.com (mailout4.samsung.com [203.254.224.34]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M8E002YRWIUVY60@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 08 Aug 2012 10:08:59 +0900 (KST) Received: from NOINKIDAE02 ([10.90.51.52]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M8E002UFWIZDE00@mmp1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 08 Aug 2012 10:08:59 +0900 (KST) In-reply-to: <1344235580-3030-5-git-send-email-sachin.kamat@linaro.org> Content-language: ko List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: 'Sachin Kamat' , dri-devel@lists.freedesktop.org Cc: patches@linaro.org List-Id: dri-devel@lists.freedesktop.org > -----Original Message----- > From: Sachin Kamat [mailto:sachin.kamat@linaro.org] > Sent: Monday, August 06, 2012 3:46 PM > To: dri-devel@lists.freedesktop.org > Cc: inki.dae@samsung.com; airlied@linux.ie; sachin.kamat@linaro.org; > patches@linaro.org > Subject: [PATCH 4/5] drm/exynos: Use devm_kzalloc in exynos_drm_hdmi.c > file > > devm_kzalloc is a device managed function and makes freeing and error > handling simpler. > > Signed-off-by: Sachin Kamat > --- > drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c > b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c > index 8ffcdf8..3fdf0b6 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c > @@ -345,7 +345,7 @@ static int __devinit exynos_drm_hdmi_probe(struct > platform_device *pdev) > > DRM_DEBUG_KMS("%s\n", __FILE__); > > - ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); > + ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL); > if (!ctx) { > DRM_LOG_KMS("failed to alloc common hdmi context.\n"); > return -ENOMEM; > @@ -371,7 +371,6 @@ static int __devexit exynos_drm_hdmi_remove(struct > platform_device *pdev) > DRM_DEBUG_KMS("%s\n", __FILE__); > > exynos_drm_subdrv_unregister(&ctx->subdrv); > - kfree(ctx); > > return 0; > } > -- > 1.7.4.1 Applied. Thanks for your patch.