From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH] DRM: Armada: Use devm_ioremap_resource()
Date: Tue, 08 Apr 2014 13:38:27 +0900
Message-ID: <008101cf52e4$627e76f0$277b64d0$%han@samsung.com>
References: <001e01cf4ed3$ff410170$fdc30450$%han@samsung.com>
 <20140407105316.GF25718@ulmo>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25])
 by gabe.freedesktop.org (Postfix) with ESMTP id A7ABF6E81F
 for <dri-devel@lists.freedesktop.org>; Mon,  7 Apr 2014 21:38:30 -0700 (PDT)
Received: from epcpsbgr3.samsung.com
 (u143.gpu120.samsung.co.kr [203.254.230.143])
 by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01
 (7.0.4.24.0) 64bit (built Nov 17 2011))
 with ESMTP id <0N3P00KDM3K3XTE0@mailout2.samsung.com> for
 dri-devel@lists.freedesktop.org; Tue, 08 Apr 2014 13:38:27 +0900 (KST)
In-reply-to: <20140407105316.GF25718@ulmo>
Content-language: ko
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: 'Thierry Reding' <thierry.reding@gmail.com>
Cc: 'Russell King' <rmk+kernel@arm.linux.org.uk>, 'Jingoo Han' <jg1.han@samsung.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Monday, April 07, 2014 7:53 PM, Thierry Reding wrote:
> On Thu, Apr 03, 2014 at 09:31:04AM +0900, Jingoo Han wrote:
> > Use devm_ioremap_resource() because devm_request_and_ioremap() is
> > obsoleted by devm_ioremap_resource().
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> >  drivers/gpu/drm/armada/armada_crtc.c |    6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/armada/armada_crtc.c b/drivers/gpu/drm/armada/armada_crtc.c
> > index d8e3982..23b0123 100644
> > --- a/drivers/gpu/drm/armada/armada_crtc.c
> > +++ b/drivers/gpu/drm/armada/armada_crtc.c
> > @@ -1037,10 +1037,10 @@ int armada_drm_crtc_create(struct drm_device *dev, unsigned num,
> >  	if (ret)
> >  		return ret;
> >
> > -	base = devm_request_and_ioremap(dev->dev, res);
> > -	if (!base) {
> > +	base = devm_ioremap_resource(dev->dev, res);
> > +	if (IS_ERR(base)) {
> >  		DRM_ERROR("failed to ioremap register\n");
> > -		return -ENOMEM;
> > +		return PTR_ERR(base);
> 
> While at it, perhaps you should drop the error message too because
> devm_ioremap_resource() already prints one in all failure cases.

Oh, right! It is my mistake. I will remove the error message.
Thank you for your comment.

Best regards,
Jingoo Han