From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: RE: [PATCH v2 12/26] drm/exynos: Split manager/display/subdrv Date: Thu, 17 Oct 2013 17:21:19 +0900 Message-ID: <00fb01cecb11$db9cec20$92d6c460$%dae@samsung.com> References: <1381951616-12548-1-git-send-email-seanpaul@chromium.org> <1381951616-12548-13-git-send-email-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id CC817E68E4 for ; Thu, 17 Oct 2013 01:21:21 -0700 (PDT) Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MUT000HS0I3ECV0@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 17 Oct 2013 17:21:20 +0900 (KST) In-reply-to: <1381951616-12548-13-git-send-email-seanpaul@chromium.org> Content-language: ko List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: 'Sean Paul' , dri-devel@lists.freedesktop.org Cc: marcheu@chromium.org List-Id: dri-devel@lists.freedesktop.org > -----Original Message----- > From: Sean Paul [mailto:seanpaul@chromium.org] > Sent: Thursday, October 17, 2013 4:27 AM > To: dri-devel@lists.freedesktop.org; inki.dae@samsung.com > Cc: airlied@linux.ie; tomasz.figa@gmail.com; marcheu@chromium.org; Sean > Paul > Subject: [PATCH v2 12/26] drm/exynos: Split manager/display/subdrv > > This patch splits display and manager from subdrv. The result is that > crtc functions can directly call into manager callbacks and encoder > functions can directly call into display callbacks. This will allow > us to remove the exynos_drm_hdmi shim and support mixer/hdmi & fimd/dp > with common code. > > Signed-off-by: Sean Paul > --- > > Changes in v2: > - Pass display into display_ops instead of context Sorry but it seems like more reasonable to pass device object into display_ops and manager_ops. I'm not sure but display_ops could be implemented in other framework based driver such as CDF based lcd panel driver. So if you pass display - it's specific to exynos drm framework - into display_ops, the other framework based driver should include specific exynos drm header. And another one, the patch 6 passes manager object to manager_ops, and for this, you made the manager object to be set to driver data; platform_set_drvdata(pdev, &manager). That isn't reasonable. Generally, driver_data would point to device driver's context object. Thanks, Inki Dae