From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dan Carpenter <error27@gmail.com>, hughd@google.com
Cc: "open list:INTEL DRM DRIVERS..." <dri-devel@lists.freedesktop.org>
Subject: Re: drm/i915: double unlock in intel_setup_overlay()
Date: Thu, 23 Jun 2011 20:20:55 +0100 [thread overview]
Message-ID: <013811$ive1b@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <20110623180616.GO14591@shale.localdomain>
On Thu, 23 Jun 2011 21:06:16 +0300, Dan Carpenter <error27@gmail.com> wrote:
> Smatch complains about the recent locking changes in
> intel_setup_overlay() that it unlocks twice on an error path. I was
> also curious if we shouldn't call i915_gem_object_unpin() on that
> error path. I don't know the drm code well enough to know about
> unpinning so I'm sending this bug report instead of patching it
> myself. :)
Right, along the 945+ error path we need to unpin. Where did the locking
fixes land, I don't see the updated intel_overlay.c to comment upon the
double unlock?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2011-06-23 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 18:06 drm/i915: double unlock in intel_setup_overlay() Dan Carpenter
2011-06-23 19:20 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='013811$ive1b@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=error27@gmail.com \
--cc=hughd@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox