From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kieran Bingham Subject: Re: [PATCH] drm: rcar-du: Revert "drm: rcar-du: Use __drm_atomic_helper_plane_reset instead of copying the logic" Date: Mon, 17 Sep 2018 11:56:23 +0100 Message-ID: <013a8df0-6bea-e06e-4e69-a7669e8f1bb5@ideasonboard.com> References: <20180914200949.25763-1-kieran.bingham+renesas@ideasonboard.com> <47884203-31b8-8389-d502-f5c0795c8d1d@ideasonboard.com> <20180917091035.GB31483@e114479-lin.cambridge.arm.com> Reply-To: kieran.bingham+renesas@ideasonboard.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB44289CFA for ; Mon, 17 Sep 2018 10:56:28 +0000 (UTC) In-Reply-To: <20180917091035.GB31483@e114479-lin.cambridge.arm.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alexandru-Cosmin Gheorghe , Laurent Pinchart Cc: linux-renesas-soc@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgQWxleGFuZHJ1LAoKT24gMTcvMDkvMTggMTA6MTAsIEFsZXhhbmRydS1Db3NtaW4gR2hlb3Jn aGUgd3JvdGU6Cj4gSGkgS2llcmFuLAo+IAo+IFNvcnJ5IGZvciB0aGF0IGFuZCB0aGFua3MgZm9y IGdldHRpbmcgdG8gdGhlIGJvdHRvbSBvZiBpdC4KCk5vIHdvcnJpZXMsCgoKPiBPbiBGcmksIFNl cCAxNCwgMjAxOCBhdCAxMToyODowNVBNICswMTAwLCBLaWVyYW4gQmluZ2hhbSB3cm90ZToKPj4g SGkgTGF1cmVudCwKPj4KPj4gSSd2ZSBsb29rZWQgdGhyb3VnaCBhIGJpdCBmdXJ0aGVyIHRvIHRy eSB0byB1bmRlcnN0YW5kIHRoaXMgaXNzdWUgYW5kIEkKPj4gdGhpbmsgSSBoYXZlIGlkZW50aWZp ZWQgYSBwb3NzaWJsZS9wcm9iYWJsZSBjYXVzZS4KPj4KPj4gQmVmb3JlIGNvbW1pdCAxNjFhZDY1 M2Q2YzksIHdlICphbHdheXMqIHNldCB0aGUgcGxhbmUtPnN0YXRlLT5hbHBoYSBhcwo+PiBEUk1f QkxFTkRfQUxQSEFfT1BBUVVFLiAoMHhmZmZmKQo+Pgo+PiBBZnRlciB0aGlzIGNvbW1pdCwgdGhl IF9fZHJtX2F0b21pY19oZWxwZXJfcGxhbmVfcmVzZXQoKSBjYWxsIHdpbGwgb25seQo+PiBzZXQg c3RhdGUtPmFscGhhIHRvIDB4ZmZmZiBpZiB0aGUgYWxwaGFfcHJvcGVydHkgaXMgc2V0Ogo+Pgo+ PiAgICAgICAgIGlmIChwbGFuZS0+YWxwaGFfcHJvcGVydHkpCj4+ICAgICAgICAgICAgICAgICBz dGF0ZS0+YWxwaGEgPSBwbGFuZS0+YWxwaGFfcHJvcGVydHktPnZhbHVlc1sxXTsKPj4KPj4gVGhl biB0aGUgc3RhdGUtPmFscGhhIHZhbHVlIGlzIGFsd2F5cyByZWZlcmVuY2VkIGluCj4+IHJjYXJf ZHVfdnNwX3BsYW5lX3NldHVwKCkgYW5kIHBhc3NlZCB0byB0aGUgVlNQIGZvciB0aGF0IGxheWVy Lgo+Pgo+Pgo+PiBXZSBjYW4gc2VlIGluIHJjYXJfZHVfcGxhbmVzX2luaXQoKSwgdGhhdCBhbGwg T1ZFUkxBWSBwbGFuZXMgYXJlCj4+IGNvbmZpZ3VyZWQgdG8gaGF2ZSB0aGlzIHByb3Blcnkgd2l0 aCBhIGNhbGwgdG8KPj4gZHJtX3BsYW5lX2NyZWF0ZV9hbHBoYV9wcm9wZXJ0eSgmcGxhbmUtPnBs YW5lKTsgaG93ZXZlciAtIHRoZSBQUklNQVJZCj4+IHBsYW5lIGlzIHNraXBwZWQgb3ZlciBiZWZv cmUgc2V0dGluZyB0aGlzLgo+Pgo+Pgo+PiBJIGJlbGlldmUgSSByZWNhbGwgc2VlaW5nIHRoYXQg dGhlIGttcy10ZXN0LXBsYW5lcG9zaXRpb24ucHkKPj4gc3VjY2Vzc2Z1bGx5IHNob3dlZCBvdGhl ciBwbGFuZXMgd2hpY2ggd2VyZSBub3QgdGhlIGJhY2sgb25lIChJJ20gbm93Cj4+IGdvaW5nIGZy b20gaGF6eSBtZW1vcnkgb2YgdGhpcyBhZnRlcm5vb24gLSBidXQgSSBhbSBmYWlybHkgc3VyZSBJ IHNhdyB0aGlzKQo+Pgo+Pgo+PiBUaGlzIGltcGxpZXMgdGhhdCB0aGUgcHJpbWFyeSBwbGFuZXMg YXJlIGJlaW5nIGluY29ycmVjdGx5IGNvbmZpZ3VyZWQgLQo+PiBidXQgdGhlIG92ZXJsYXkgcGxh bmVzIGFyZSBzdGlsbCBmdW5jdGlvbmluZyBhcyBleHBlY3RlZC4KPj4KPj4gU28gSSBiZWxpZXZl IHdlIGNvdWxkIG1vdmUgdGhlIGNhbGwgdG8gY3JlYXRlIHRoZSBhbHBoYSBwcm9wZXJ0eToKPj4g CWRybV9wbGFuZV9jcmVhdGVfYWxwaGFfcHJvcGVydHkoJnBsYW5lLT5wbGFuZSk7Cj4+Cj4+IHRv IG9jY3VyIGJlZm9yZSB0aGUgaWYgKHR5cGUgPT0gRFJNX1BMQU5FX1RZUEVfUFJJTUFSWSkgY29u dGludWU7IHN0YXRlbWVudC4KPj4KPiAKPiBJIGRvbid0IHNlZSBhbnkgcmVzb24gd2h5IHRoZSBw cmltYXJ5IHBsYW5lIHNob3VsZG4ndCBhZHZlcnRpc2UgYW4KPiBhbHBoYSBhcyB3ZWxsLgoKCk9L IC0gc28gSSB0aGluayB3ZSBwZXJoYXBzIHNob3VsZCBtYWtlIHN1cmUgdGhhdCB3ZSBlbmFibGUg YWxwaGEgZm9yIG91cgpwcmltYXJ5IHBsYW5lIGluIHJjYXItZHUuCgoKPj4gSXQgbWF5IG9yIG1h eSBub3QgbWFrZSBzZW5zZSB0byBoYXZlIGFscGhhIGJsZW5kaW5nIHN1cHBvcnQgb24gdGhlCj4+ IFBSSU1BUlkgcGxhbmUuIEF0IHRoZSByaXNrIG9mIHNvdW5kaW5nIHNpbGx5IC0gY2FuIHdlIGhh dmUgYW55dGhpbmcgZWxzZQo+PiBiZWhpbmQgdGhlIFBSSU1BUlkgcGxhbmUgPyAoSSBkb3VidCB0 aGlzLCBJIGRvbid0IHRoaW5rIHdlIGhhdmUgYW55Cj4+IGV4dHJhIGxheWVycyBoaWRpbmcgYW55 d2hlcmUpCj4gCj4gSSB0aGluayB0aGUgc2FtZSBxdWVzdGlvbiBjb3VsZCBhcHBseSB0byBzaXR1 YXRpb25zIHdoZXJlIFBSSU1BUlkgaXMKPiBkaXNhYmxlZCBhbmQgeW91IGhhdmUganVzdCBvbmUg T1ZFUkxBWSBwbGFuZSBlbmFibGVkLgo+IAo+Pgo+PiBPdGhlcndpc2UsIEkgdGhpbmsgd2Ugd291 bGQgbmVlZCB0byBpbnRlcmNlcHQgdGhlIGNvbmZpZ3VyYXRpb24gb2YgdGhlCj4+IGFscGhhIGJs ZW5kaW5nIGFuZCBtYWtlIHN1cmUgdGhhdCBhbGwgUFJJTUFSWSBwbGFuZXMgYXJlIGNvbmZpZ3Vy ZWQgdG8KPj4gYmUgZnVsbHkgb3BhcXVlIGluIG91ciBsYXllcnMuIEkgdGhpbmsgdGhpcyBpcyBo YXBwZW5pbmcgaW4KPj4gcmNhcl9kdV92c3BfcGxhbmVfc2V0dXAoKS4KPj4KPj4gQnV0IHJhdGhl ciB0aGFuIHB1dCBpbiBhIGNvbmRpdGlvbmFsIGluIHRoZXJlLCBJIHRoaW5rIEknZCByYXRoZXIg anVzdAo+PiBpbml0aWFsaXNlIHRoZSBwbGFuZS0+c3RhdGUtPmFscGhhID0gRFJNX0JMRU5EX0FM UEhBX09QQVFVRSBpbiBvdXIKPj4gcmNhcl9kdV92c3BfcGxhbmVfcmVzZXQoKSBjYWxsIGFuZCBi ZSBkb25lIHdpdGggaXQuCj4gCj4gSSB0aGluayB5b3UgY291bGQgZG8gbW9yZSBhbmQganVzdCBn byBpbgo+IF9fZHJtX2F0b21pY19oZWxwZXJfcGxhbmVfcmVzZXQgYW5kIGFsd2F5cyBpbml0aWFs aXplcyBwbGFuZS0+YWxwaGEKPiB3aXRoIERSTV9CTEVORF9BTFBIQV9PUEFRVUUsIHRoaXMgd2F5 IG5vYm9keSBlbHNlIGhpdHMgdGhpcyBwcm9ibGVtLgoKSSB0aGluayB0aGlzIHNvdW5kcyBsaWtl IGEgZ29vZCB0aGluZyB0b28uCgpJcyBEUk1fQkxFTkRfQUxQSEFfT1BBUVVFIGEgc3VpdGFibGUg aW5pdGlhbCB2YWx1ZSBmb3IgYWxsIG9mIHRoZSBvdGhlcgp1c2VycyBvZiB0aGUgaGVscGVyID8K Ckkgc3VzcGVjdCB0aGUgYW5zd2VyIGlzIHllcywgYnV0IEknbGwgdHJ5IHRvIGRvIGEgYml0IG9m IGRpZ2dpbmcgdGhyb3VnaAp0aGUgb3RoZXIgZHJpdmVycyB0b21vcnJvdy4KCkkgcHJlc3VtZSB3 ZSBjb3VsZCB0aGVuIGp1c3QgcmVtb3ZlIHRoZSBjb25kaXRpb25hbCBjaGVjayBhbmQgYWx3YXlz CmluaXRpYWxpc2UgdG8gT1BBUVVFIC4uLgoKT3Igb3RoZXJ3aXNlIHBlcmhhcHMgbWF5YmUgaW5p dGlhbGlzaW5nIGFzIGFuICdlbHNlJyBpZiBubyBhbHBoYQpwcm9wZXJ0eSBpcyBwcm92aWRlZC4K Ci0tClJlZ2FyZHMKCktpZXJhbgoKCgoKCgo+Pgo+PiBBbnl3YXkgLSBqdXN0IHNvbWUgbXVzaW5n cyBhbmQgdGhvdWdodHMgYXQgdGhpcyBzdGFnZSwgd2UgY2FuCj4+IGludmVzdGlnYXRlIGluIG1v cmUgZGV0YWlsIG5leHQgd2Vlay4KPj4KPj4gLS0KPj4gUmVnYXJkcwo+Pgo+PiBLaWVyYW4KPj4K Pj4KPj4gT24gMTQvMDkvMTggMjE6MDksIEtpZXJhbiBCaW5naGFtIHdyb3RlOgo+Pj4gQ29tbWl0 OiAxNjFhZDY1M2Q2YzkgKCJkcm06IHJjYXItZHU6IFVzZSBfX2RybV9hdG9taWNfaGVscGVyX3Bs YW5lX3Jlc2V0Cj4+PiBpbnN0ZWFkIG9mIGNvcHlpbmcgdGhlIGxvZ2ljIikgY2F1c2VzIGEgcmVn cmVzc2lvbiBpbiB0aGUgUi1DYXIgRFUKPj4+IGRpc3BsYXkgZHJpdmVyLCBhbmQgcHJldmVudHMg YW55IG91dHB1dCBmcm9tIGJlaW5nIGRpc3BsYXllZC4KPj4+Cj4+PiBUaGUgZGlzcGxheSBhcHBl YXJzIHRvIGZ1bmN0aW9uIGNvcnJlY3RseSBidXQgb25seSBhIGJsYWNrIHNjcmVlbiBpcwo+Pj4g ZXZlciB2aXNpYmxlLgo+Pj4KPj4+IFJldmVydCB0aGUgY29tbWl0Lgo+Pj4KPj4+IFNpZ25lZC1v ZmYtYnk6IEtpZXJhbiBCaW5naGFtIDxraWVyYW4uYmluZ2hhbStyZW5lc2FzQGlkZWFzb25ib2Fy ZC5jb20+Cj4+Pgo+Pj4gLS0tCj4+Pgo+Pj4gTG9va2luZyB0aHJvdWdoIHRoZSBjb2RlLCB0aGUg cmVhc29uIGZvciB0aGlzIGlzc3VlIGlzbid0IHBhcnRpY3VsYXJseQo+Pj4gb2J2aW91cyAtIGFu ZCB3aWxsIG5lZWQgc29tZSBmdXJ0aGVyIGV4cGxvcmF0aW9uLCB3aGljaCBJIGNhbid0IGxvb2sg YXQKPj4+IHVudGlsIFR1ZXNkYXkuIFNvIEknbSBwb3N0aW5nIHRoaXMgcmV2ZXJ0IHBhdGNoIHRv Cj4+Pgo+Pj4gIEEpIFJlcG9ydCB0aGUgaXNzdWUKPj4+ICBCKSBQcm92aWRlIGEgdGVtcG9yYXJ5 IGZpeAo+Pj4KPj4+IEkgc3VzcGVjdCBlaXRoZXIgdGhlIGluaXRpYWwgYWxwaGEgdmFsdWUgaXMg bm90IHNldCBjb3JyZWN0bHkgb3Igc2V0dGluZwo+Pj4KPj4+ICAgICAgICAgIHN0YXRlLT5waXhl bF9ibGVuZF9tb2RlID0gRFJNX01PREVfQkxFTkRfUFJFTVVMVEk7Cj4+Pgo+Pj4gY2F1c2VzIHNv bWUgc2lkZSBlZmZlY3QgcGVyaGFwcy4gVGhlcmUncyBub3QgbXVjaCBlbHNlIHRoYXQgY291bGQg YmUKPj4+IGRpZmZlcmVudCBiZXR3ZWVuIHRoZSBoZWxwZXIsIGFuZCB0aGUgb3JpZ2luYWwgY29k ZS4KPj4+Cj4+PiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9wbGFuZS5jIHwgNiAr KysrLS0KPj4+ICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X3ZzcC5jICAgfCA1ICsr KystCj4+PiAgMiBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0p Cj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfcGxh bmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfcGxhbmUuYwo+Pj4gaW5kZXgg OWUwNzc1OGE3NTVjLi41YzI0NjJhZmU0MDggMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vcmNhci1kdS9yY2FyX2R1X3BsYW5lLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2Fy LWR1L3JjYXJfZHVfcGxhbmUuYwo+Pj4gQEAgLTY4NiwxMiArNjg2LDE0IEBAIHN0YXRpYyB2b2lk IHJjYXJfZHVfcGxhbmVfcmVzZXQoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUpCj4+PiAgCWlmIChz dGF0ZSA9PSBOVUxMKQo+Pj4gIAkJcmV0dXJuOwo+Pj4gIAo+Pj4gLQlfX2RybV9hdG9taWNfaGVs cGVyX3BsYW5lX3Jlc2V0KHBsYW5lLCAmc3RhdGUtPnN0YXRlKTsKPj4+IC0KPj4+ICAJc3RhdGUt Pmh3aW5kZXggPSAtMTsKPj4+ICAJc3RhdGUtPnNvdXJjZSA9IFJDQVJfRFVfUExBTkVfTUVNT1JZ Owo+Pj4gIAlzdGF0ZS0+Y29sb3JrZXkgPSBSQ0FSX0RVX0NPTE9SS0VZX05PTkU7Cj4+PiAgCXN0 YXRlLT5zdGF0ZS56cG9zID0gcGxhbmUtPnR5cGUgPT0gRFJNX1BMQU5FX1RZUEVfUFJJTUFSWSA/ IDAgOiAxOwo+Pj4gKwo+Pj4gKwlwbGFuZS0+c3RhdGUgPSAmc3RhdGUtPnN0YXRlOwo+Pj4gKwlw bGFuZS0+c3RhdGUtPmFscGhhID0gRFJNX0JMRU5EX0FMUEhBX09QQVFVRTsKPj4+ICsJcGxhbmUt PnN0YXRlLT5wbGFuZSA9IHBsYW5lOwo+Pj4gIH0KPj4+ICAKPj4+ICBzdGF0aWMgaW50IHJjYXJf ZHVfcGxhbmVfYXRvbWljX3NldF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPj4+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X3ZzcC5jIGIvZHJp dmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV92c3AuYwo+Pj4gaW5kZXggNDU3NjExOWU3Nzc3 Li4zMTcwYjEyNmNmYmEgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9y Y2FyX2R1X3ZzcC5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X3Zz cC5jCj4+PiBAQCAtMzQxLDggKzM0MSwxMSBAQCBzdGF0aWMgdm9pZCByY2FyX2R1X3ZzcF9wbGFu ZV9yZXNldChzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSkKPj4+ICAJaWYgKHN0YXRlID09IE5VTEwp Cj4+PiAgCQlyZXR1cm47Cj4+PiAgCj4+PiAtCV9fZHJtX2F0b21pY19oZWxwZXJfcGxhbmVfcmVz ZXQocGxhbmUsICZzdGF0ZS0+c3RhdGUpOwo+Pj4gKwlzdGF0ZS0+c3RhdGUuYWxwaGEgPSBEUk1f QkxFTkRfQUxQSEFfT1BBUVVFOwo+Pj4gIAlzdGF0ZS0+c3RhdGUuenBvcyA9IHBsYW5lLT50eXBl ID09IERSTV9QTEFORV9UWVBFX1BSSU1BUlkgPyAwIDogMTsKPj4+ICsKPj4+ICsJcGxhbmUtPnN0 YXRlID0gJnN0YXRlLT5zdGF0ZTsKPj4+ICsJcGxhbmUtPnN0YXRlLT5wbGFuZSA9IHBsYW5lOwo+ Pj4gIH0KPj4+ICAKPj4+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9wbGFuZV9mdW5jcyByY2Fy X2R1X3ZzcF9wbGFuZV9mdW5jcyA9IHsKPj4+Cj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK