From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Paul Subject: Re: [PATCH] drm/mst: Fix MST sideband up-reply failure handling Date: Thu, 23 May 2019 18:09:56 -0400 Message-ID: <016079c3ec78cddeaa2181a4c15ae2b5b6df2b88.camel@redhat.com> References: <20190523212433.9058-1-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id B4CAE6E039 for ; Thu, 23 May 2019 22:09:58 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id k24so8679293qtq.7 for ; Thu, 23 May 2019 15:09:58 -0700 (PDT) In-Reply-To: <20190523212433.9058-1-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Imre Deak , dri-devel@lists.freedesktop.org Cc: Dave Airlie List-Id: dri-devel@lists.freedesktop.org UGF0Y2ggbW9zdGx5IGxvb2tzIGdvb2QgdG8gbWUsIG9uZSBjb21tZW50IGJlbG93CgpPbiBGcmks IDIwMTktMDUtMjQgYXQgMDA6MjQgKzAzMDAsIEltcmUgRGVhayB3cm90ZToKPiBGaXggdGhlIGJy ZWFrYWdlIHJlc3VsdGluZyBpbiB0aGUgc3RhY2t0cmFjZSBiZWxvdywgZHVlIHRvIHR4IHF1ZXVl Cj4gYmVpbmcgZnVsbCB3aGVuIHRyeWluZyB0byBzZW5kIGFuIHVwLXJlcGx5LiB0eG1zZy0+c2Vx bm8gaXMgLTEgaW4gdGhpcwo+IGNhc2UgbGVhZGluZyB0byBhIGNvcnJ1cHRpb24gb2YgdGhlIG1z dGIgb2JqZWN0IGJ5Cj4gCj4gCXR4bXNnLT5kc3QtPnR4X3Nsb3RzW3R4bXNnLT5zZXFub10gPSBO VUxMOwo+IAo+IGluIHByb2Nlc3Nfc2luZ2xlX3VwX3R4X3Fsb2NrKCkuCj4gCj4gWyAgKzAsMDA1 MTYyXSBbZHJtOnByb2Nlc3Nfc2luZ2xlX3R4X3Fsb2NrIFtkcm1fa21zX2hlbHBlcl1dCj4gc2V0 X2hkcl9mcm9tX2RzdF9xbG9jazogZmFpbGVkIHRvIGZpbmQgc2xvdAo+IFsgICswLDAwMDAxNV0g W2RybTpkcm1fZHBfc2VuZF91cF9hY2tfcmVwbHkuY29uc3Rwcm9wLjE5IFtkcm1fa21zX2hlbHBl cl1dCj4gZmFpbGVkIHRvIHNlbmQgbXNnIGluIHEgLTExCj4gWyAgKzAsMDAwOTM5XSBCVUc6IGtl cm5lbCBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2UsIGFkZHJlc3M6Cj4gMDAwMDAwMDAwMDAwMDVh MAo+IFsgICswLDAwNjk4Ml0gI1BGOiBzdXBlcnZpc29yIHdyaXRlIGFjY2VzcyBpbiBrZXJuZWwg bW9kZQo+IFsgICswLDAwNTIyM10gI1BGOiBlcnJvcl9jb2RlKDB4MDAwMikgLSBub3QtcHJlc2Vu dCBwYWdlCj4gWyAgKzAsMDA1MTM1XSBQR0QgMCBQNEQgMAo+IFsgICswLDAwMjU4MV0gT29wczog MDAwMiBbIzFdIFBSRUVNUFQgU01QIE5PUFRJCj4gWyAgKzAsMDA0MzU5XSBDUFU6IDEgUElEOiAx MjAwIENvbW06IGt3b3JrZXIvdTE2OjMgVGFpbnRlZDoKPiBHICAgICBVICAgICAgICAgICAgNS4y LjAtcmMxKyAjNDEwCj4gWyAgKzAsMDA4NDMzXSBIYXJkd2FyZSBuYW1lOiBJbnRlbCBDb3Jwb3Jh dGlvbiBJY2UgTGFrZSBDbGllbnQKPiBQbGF0Zm9ybS9JY2VMYWtlIFUgRERSNCBTT0RJTU0gUEQg UlZQLCBCSU9TIElDTFNGV1IxLlIwMC4zMTc1LkEwMC4xOTA0MjYxNDI4Cj4gMDQvMjYvMjAxOQo+ IFsgICswLDAxMzMyM10gV29ya3F1ZXVlOiBpOTE1LWRwIGk5MTVfZGlncG9ydF93b3JrX2Z1bmMg W2k5MTVdCj4gWyAgKzAsMDA1Njc2XSBSSVA6IDAwMTA6cXVldWVfd29ya19vbisweDE5LzB4NzAK PiBbICArMCwwMDQzNzJdIENvZGU6IGZmIGZmIGZmIDBmIDFmIDQwIDAwIDY2IDJlIDBmIDFmIDg0 IDAwIDAwIDAwIDAwIDAwIDQxIDU2Cj4gNDkgODkgZjYgNDEgNTUgNDEgODkgZmQgNDEgNTQgNTUg NTMgNDggODkgZDMgOWMgNWQgZmEgZTggZTcgODEgMGMgMDAgPGYwPiA0OAo+IDBmIGJhIDJiIDAw IDczIDMxIDQ1IDMxIGU0IGY3IGM1IDAwIDAyIDAwIDAwIDc0IDEzIGU4IGNmIDdmCj4gWyAgKzAs MDE4NzUwXSBSU1A6IDAwMTg6ZmZmZmM5MDAwMDdkZmM1MCBFRkxBR1M6IDAwMDEwMDA2Cj4gWyAg KzAsMDA1MjIyXSBSQVg6IDAwMDAwMDAwMDAwMDAwNDYgUkJYOiAwMDAwMDAwMDAwMDAwNWEwIFJD WDoKPiAwMDAwMDAwMDAwMDAwMDAxCj4gWyAgKzAsMDA3MTMzXSBSRFg6IDAwMDAwMDAwMDAwMWI2 MDggUlNJOiAwMDAwMDAwMDAwMDAwMDAwIFJESToKPiBmZmZmZmZmZjgyMTIxOTcyCj4gWyAgKzAs MDA3MTI5XSBSQlA6IDAwMDAwMDAwMDAwMDAyMDIgUjA4OiAwMDAwMDAwMDAwMDAwMDAwIFIwOToK PiAwMDAwMDAwMDAwMDAwMDAxCj4gWyAgKzAsMDA3MTI5XSBSMTA6IDAwMDAwMDAwMDAwMDAwMDAg UjExOiAwMDAwMDAwMDAwMDAwMDAwIFIxMjoKPiBmZmZmODg4NDdiZmE1MDk2Cj4gWyAgKzAsMDA3 MTMxXSBSMTM6IDAwMDAwMDAwMDAwMDAwMTAgUjE0OiBmZmZmODg4NDljMDhmM2Y4IFIxNToKPiAw MDAwMDAwMDAwMDAwMDAwCj4gWyAgKzAsMDA3MTI4XSBGUzogIDAwMDAwMDAwMDAwMDAwMDAoMDAw MCkgR1M6ZmZmZjg4ODQ5ZGM4MDAwMCgwMDAwKQo+IGtubEdTOjAwMDAwMDAwMDAwMDAwMDAKPiBb ICArMCwwMDgwODNdIENTOiAgMDAxMCBEUzogMDAwMCBFUzogMDAwMCBDUjA6IDAwMDAwMDAwODAw NTAwMzMKPiBbICArMCwwMDU3NDldIENSMjogMDAwMDAwMDAwMDAwMDVhMCBDUjM6IDAwMDAwMDAw MDUyMTAwMDYgQ1I0Ogo+IDAwMDAwMDAwMDA3NjBlZTAKPiBbICArMCwwMDcxMjhdIFBLUlU6IDU1 NTU1NTU0Cj4gWyAgKzAsMDAyNzIyXSBDYWxsIFRyYWNlOgo+IFsgICswLDAwMjQ1OF0gIGRybV9k cF9tc3RfaGFuZGxlX3VwX3JlcSsweDUxNy8weDU0MCBbZHJtX2ttc19oZWxwZXJdCj4gWyAgKzAs MDA2MTk3XSAgPyBkcm1fZHBfbXN0X2hwZF9pcnErMHg1Yi8weDljMCBbZHJtX2ttc19oZWxwZXJd Cj4gWyAgKzAsMDA1NzY0XSAgZHJtX2RwX21zdF9ocGRfaXJxKzB4NWIvMHg5YzAgW2RybV9rbXNf aGVscGVyXQo+IFsgICswLDAwNTYyM10gID8gaW50ZWxfZHBfaHBkX3B1bHNlKzB4MjA1LzB4Mzcw IFtpOTE1XQo+IFsgICswLDAwNTAxOF0gIGludGVsX2RwX2hwZF9wdWxzZSsweDIwNS8weDM3MCBb aTkxNV0KPiBbICArMCwwMDQ4MzZdICBpOTE1X2RpZ3BvcnRfd29ya19mdW5jKzB4YmIvMHgxNDAg W2k5MTVdCj4gWyAgKzAsMDA1MTA4XSAgcHJvY2Vzc19vbmVfd29yaysweDI0NS8weDYxMAo+IFsg ICswLDAwNDAyN10gIHdvcmtlcl90aHJlYWQrMHgzNy8weDM4MAo+IFsgICswLDAwMzY4NF0gID8g cHJvY2Vzc19vbmVfd29yaysweDYxMC8weDYxMAo+IFsgICswLDAwNDE4NF0gIGt0aHJlYWQrMHgx MTkvMHgxMzAKPiBbICArMCwwMDMyNDBdICA/IGt0aHJlYWRfcGFyaysweDgwLzB4ODAKPiBbICAr MCwwMDM2NjhdICByZXRfZnJvbV9mb3JrKzB4MjQvMHg1MAo+IAo+IENjOiBMeXVkZSBQYXVsIDxs eXVkZUByZWRoYXQuY29tPgo+IENjOiBEYXZlIEFpcmxpZSA8YWlybGllZEByZWRoYXQuY29tPgo+ IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYyB8IDYgKysrKystCj4gIDEgZmls ZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYwo+IGIvZHJpdmVycy9ncHUv ZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYwo+IGluZGV4IGRhMWFiY2ExYjllOS4uMjRjMzI1ZjRh NjE2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHBfbXN0X3RvcG9sb2d5LmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX21zdF90b3BvbG9neS5jCj4gQEAgLTE5OTYs NyArMTk5NiwxMSBAQCBzdGF0aWMgdm9pZCBwcm9jZXNzX3NpbmdsZV91cF90eF9xbG9jayhzdHJ1 Y3QKPiBkcm1fZHBfbXN0X3RvcG9sb2d5X21nciAqbWdyLAo+ICAJaWYgKHJldCAhPSAxKQo+ICAJ CURSTV9ERUJVR19LTVMoImZhaWxlZCB0byBzZW5kIG1zZyBpbiBxICVkXG4iLCByZXQpOwo+ICAK PiAtCXR4bXNnLT5kc3QtPnR4X3Nsb3RzW3R4bXNnLT5zZXFub10gPSBOVUxMOwo+ICsJaWYgKHR4 bXNnLT5zZXFubyAhPSAtMSkgewo+ICsJCVdBUk5fT04oKHVuc2lnbmVkKXR4bXNnLT5zZXFubyA+ Cj4gKwkJCUFSUkFZX1NJWkUodHhtc2ctPmRzdC0+dHhfc2xvdHMpKTsKCk5vdCAxMDAlIHN1cmUg b24gdGhpcyBuaXRwaWNrIG15c2VsZiBidXQsIGlmIHdlIGtub3cgdGhhdCB0eG1zZy0+c2Vxbm8g aXMKYWJvdXQgdG8gZ28gb3V0IG9mIGJvdW5kcyBzaG91bGRuJ3Qgd2UgYWxzbyB0cnkgdG8gdGFr ZSBhY3Rpb24gdG8gc3RvcCBpdD8KbGlrZQoKaWYgKCFXQVJOX09OKCh1bnNpZ25lZCl0eG1zZy0+ c2Vxbm8gPiBBUlJBWV9TSVpFKHR4bXNnLT5kc3QtPnR4X3Nsb3RzKSkpCiAgICAgICAgdHhtc2ct PmRzdC0+dHhfc2xvdHNbdHhtc2ctPnNlcW5vXSA9IE5VTEw7CgoKCj4gKwkJdHhtc2ctPmRzdC0+ dHhfc2xvdHNbdHhtc2ctPnNlcW5vXSA9IE5VTEw7Cj4gKwl9Cj4gIH0KPiAgCj4gIHN0YXRpYyB2 b2lkIGRybV9kcF9xdWV1ZV9kb3duX3R4KHN0cnVjdCBkcm1fZHBfbXN0X3RvcG9sb2d5X21nciAq bWdyLAotLSAKQ2hlZXJzLAoJTHl1ZGUgUGF1bAoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVs