From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] Fixes: fc2a69f3903d ("drm/atomic: Handling the case when, setting old crtc for plane") Date: Wed, 5 Sep 2018 11:36:20 +0200 Message-ID: <01729c87-3e8b-4079-0deb-86d885f0f408@linux.intel.com> References: <279cbe23-ed68-2729-bba9-61953a65a1cb@hohmatik.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <279cbe23-ed68-2729-bba9-61953a65a1cb@hohmatik.de> Content-Language: en-US Sender: stable-owner@vger.kernel.org To: Karsten Hohmeier , dri-devel@lists.freedesktop.org Cc: Satendra Singh Thakur , Madhur Verma , Hemanshu Srivastava , Daniel Vetter , Gustavo Padovan , Sean Paul , David Airlie , stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Op 05-09-18 om 00:26 schreef Karsten Hohmeier: > Original commit causes "plane A assertion failure" on lid close/lid open > with older HP Compaq 6720s laptops (Intel Mobile GME965/GLE960). > Full bug report at "https://bugs.freedesktop.org/show_bug.cgi?id=107827". > --- > drivers/gpu/drm/drm_atomic.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index 895741e9cd7d..a59ded403657 100644 > --- a/drivers/gpu/drm/drm_atomic.c > +++ b/drivers/gpu/drm/drm_atomic.c > @@ -1433,9 +1433,7 @@ drm_atomic_set_crtc_for_plane(struct > drm_plane_state *plane_state, > { > struct drm_plane *plane = plane_state->plane; > struct drm_crtc_state *crtc_state; > - /* Nothing to do for same crtc*/ > - if (plane_state->crtc == crtc) > - return 0; > + > if (plane_state->crtc) { > crtc_state = drm_atomic_get_crtc_state(plane_state->state, > plane_state->crtc); > -- > 2.11.0 > > This patch is missing a signed-off-by. Can you add your signed-off-by, so we can apply this upstream?