Re: [RFC 4/4] drm/panel/ili9341: Support mi0283qt

["Noralf Trønnes" <noralf@tronnes.org>]

Den 30.07.2019 17.22, skrev Daniel Vetter:
> On Tue, Jul 30, 2019 at 4:30 PM Noralf Trønnes <noralf@tronnes.org> wrote:
>>
>>
>>
>> Den 29.07.2019 21.55, skrev Noralf Trønnes:
>>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
>>> ---
>>>  drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 179 ++++++++++++++++++-
>>>  1 file changed, 170 insertions(+), 9 deletions(-)
>>>
>>
>> I have realised that this will change the DRM driver name from mi0283qt
>> to drm_mipi_dbi. This means that this panel will loose its MESA kmsro[1]
>> support. I haven't tried it, but this is the first thing that gives this
>> driver any real advantage over its fbdev counterpart in
>> drivers/staging/fbtft, so I don't want to loose that.
>> So even if MIPI DBI panel support is implemented in some form, I will
>> wait with converting mi0283qt until someone has updated the kmsro driver.
> 
> Why does it change? You should be able to stuff whatever you feel like
> into the drm driver name, this doesn't have to match either your
> platform/spi/whatever driver name nor the module option.

Strictly it doesn't have to change, I could pass a mi0283qt specific
struct drm_driver to drm_mipi_dbi_panel_register() and keep the DRM
driver name.

Noralf.

> -Daniel
> 
> 
>> Noralf.
>>
>> [1]
>> https://gitlab.freedesktop.org/mesa/mesa/tree/master/src/gallium/winsys/kmsro/drm
>> https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/gallium/targets/dri/target.c
> 
> 
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel