From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE34AC83F1A for ; Wed, 23 Jul 2025 10:13:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 35A9710E15F; Wed, 23 Jul 2025 10:13:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="IBbMXJPl"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 265A510E15F for ; Wed, 23 Jul 2025 10:13:53 +0000 (UTC) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56N9F5Ev021749 for ; Wed, 23 Jul 2025 10:13:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A1Fp0VrKpCniXZvPKeA5q3E1PK5THOcusTjUp11AbC8=; b=IBbMXJPlWbhzanWP XHSwCHLB+a3ijQ/iwEMi9BNvVwvjFRrt0AYV5+kaD4xenJ8MrjCAj7aL4bhrECfF tzkTgkiWNn7/wqt/2E2Ip0oCqZgjRLOZfotcswi8JLB6fXlm5heivGKezvzLxmEx msw2ProNf7Yg6hO1eFoeWXTP0TOtClm5ucQ4wJ57SzmjhPWDuKAzhBFFZ0hm38WC mzYoUHE0eEZj8j83zO41NBWHDcIKNb4cyMb5KL5n620gafyb9tXN1O/UghBFSUYZ 0Of7YxeJG3+IG3q4K6bL8/MUg07olclUdKE/oRg4a7aumM+1m4H+vIRZbE5dSTDX xAQlvA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 481g3eqjaa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 23 Jul 2025 10:13:52 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7de3c682919so95054185a.2 for ; Wed, 23 Jul 2025 03:13:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753265631; x=1753870431; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A1Fp0VrKpCniXZvPKeA5q3E1PK5THOcusTjUp11AbC8=; b=k2JBza/vXcuIUP88l70XMybFBrq1aVtFB+pzD9BkPhiIaFLVJD5EcS+0konwPjkSmB coB5AqUFW3jMSGQ2kskV/8hXm8PU87Yjz507Ravef1uu2HFeU9pVjoeOjzM4HBdlrv6c hq4b3A72rkwGUoBy3/AFy+OBsGfLJynwG6VfP2nYU7ZAJ8Jb/z7k8BqHVX3Curw46KcD TDYTGjmcB1jEO+2SNHD0fliLxRA5fgxVjsV6a9jNmSDZOlAlk04GA/0Ds32KTOxdeEe8 Fbt8m4K6FuUu+1MuZ/6RqSx/Vhg/XBnfikSzD/nstMd8/E1tSq4ZuvKg+SVGq3v8gB5+ U2sg== X-Forwarded-Encrypted: i=1; AJvYcCUF0boFA+8+3QtPZ/zUbjiFox5eks/HzmDf7JsJFtgcBY0nvkNixED/h3Lrtb121fr6tqz8429ohY4=@lists.freedesktop.org X-Gm-Message-State: AOJu0Ywad3LresPFk6aswTEs390ziMJfWChr3+IXNaADyU6rdvx5Zvki TRJ9Mey1ATZjdUwOriDwOXq7+EcJ2YN9quDu9I28l0ycLBhZ537GkXi7VIrK8x+mjoF4/SGzVYc Lgxsv5At7BhoQ/qSGCtvt55reFDgwtgR2ndy4D/lkiRGsa19lQOdZbuFYpIeQnElHIRUvCxk= X-Gm-Gg: ASbGncsIJw/mJQ8jMxwEUTVS7DHaZ3LfpAroTYLA0EpBfBFGzJUy87EG6Pqa8AnKKBJ 1s7ipaRKj/Wd6s3qUHwHX5L8kyDP06JMtppQZvQigK36Wr/RN/eeuxMFA9kWkg77NrgPW+E9kQZ EoFYwzkNfWDhj5kqW00d4KOcbkI5ekVeIxNBM2tgEm4OkEz5YDwQITwqrBf6gzNCoFVBrTuoGju oI+dc1/TvZOlaVK8+lcIbEP8Yen7KxPdCKRedOUv90p5zlGlrJZlrcfbFlNkODFSGvbkLLtu97X WzCv1kwIBF2s6NtLAqSbFu6afZOu7tXLvzbn2snO7K4pn1Zfi6vc3Bv82utGS2YrucnnCBW8WHt MXOa2VfZVlkoZ4I8F6g== X-Received: by 2002:a05:620a:318a:b0:7df:d668:22ff with SMTP id af79cd13be357-7e62a0c1347mr135521185a.4.1753265630564; Wed, 23 Jul 2025 03:13:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEj3f1wr8H3E8T0jx6NxR/LC1BEZKnxCKVi6DM0FYNiWA0IcAlD7hCgXo8SM37cDFvPxE/gAg== X-Received: by 2002:a05:620a:318a:b0:7df:d668:22ff with SMTP id af79cd13be357-7e62a0c1347mr135518985a.4.1753265629973; Wed, 23 Jul 2025 03:13:49 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-612c8f543ddsm8186317a12.30.2025.07.23.03.13.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Jul 2025 03:13:49 -0700 (PDT) Message-ID: <02b9de9b-36c8-4db8-a1dd-65a82aee0eaf@oss.qualcomm.com> Date: Wed, 23 Jul 2025 12:13:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/17] drm/msm: a6xx: Refactor a6xx_sptprac_enable() To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250720-ifpc-support-v1-0-9347aa5bcbd6@oss.qualcomm.com> <20250720-ifpc-support-v1-2-9347aa5bcbd6@oss.qualcomm.com> <4832a160-344a-4140-a115-d4742f95825b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <4832a160-344a-4140-a115-d4742f95825b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Lz4jdpwI9kSRnhOLoUrbBRSkJ7A3JkjL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzIzMDA4NSBTYWx0ZWRfXyDOdu3vooSVn T+PCexBu49dGoL4VWwFjy77HVWi4UPJdwQk4mfwm96KfF14dPrwbdBDcDxdgEOQuwC73Tfbsa6t oeraWmK02ZUSalcJlCCoTYsPFbgsXGOVBCrlnxKus8Y3oMz6h0c1M5yZfxypNkaZSa9XOwH8wZ9 MvdPDJTbNRH13UqyzkekDi9NN3vJtsIpqSc1itTv2uN/E7DVYv9IndrHOru+oGqPLoo3Q+6RyUW u/InltrQBYH7YT5GjjRTqiMK/wxzp74dQiqEjHZPpr3qhSYA5pDCqhoQBqUFcQ4vRfP1AkcZyix g4wmUE+eew+1KIWW5kJ+t1WqE60nCHbMFF3X4gxGTkNrf47KsjKGE3qYo9glkhtRwUpm2LLyM4P c6shR6F3V8mSZ75qhFhdnrnWQiSraHwgxc3/fVTSSa/NJ4OnaiwTSbpKE4dwciQToVEyCCHK X-Authority-Analysis: v=2.4 cv=Q+fS452a c=1 sm=1 tr=0 ts=6880b5e0 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=3Acu8AJWO6yBlTze4eEA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: Lz4jdpwI9kSRnhOLoUrbBRSkJ7A3JkjL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-23_01,2025-07-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 phishscore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507230085 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 7/22/25 9:47 PM, Akhil P Oommen wrote: > On 7/22/2025 8:00 PM, Konrad Dybcio wrote: >> On 7/20/25 2:16 PM, Akhil P Oommen wrote: >>> A minor refactor to combine the subroutines for legacy a6xx GMUs under >>> a single check. This helps to avoid an unnecessary check and return >>> early from the subroutine for majority of a6xx gpus. >>> >>> Signed-off-by: Akhil P Oommen >>> --- >>> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >>> index 38c0f8ef85c3d260864541d83abe43e49c772c52..41129692d127b70e9293b82bea5ccb6b911b0bfb 100644 >>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >>> @@ -403,7 +403,10 @@ int a6xx_sptprac_enable(struct a6xx_gmu *gmu) >>> int ret; >>> u32 val; >>> >>> - if (!gmu->legacy) >>> + WARN_ON(!gmu->legacy); >>> + >>> + /* Nothing to do if GMU does the power management */ >>> + if (gmu->idle_level > GMU_IDLE_STATE_ACTIVE) >> >> This isn't quite a no-op, but I can't seem to find what the '1' value >> would map to, even in 845 kernel sources. Do we have to worry about it? > > This is fine. '1' seems to be a low power state that was removed very > early in the gmu firmware development stage. We can ignore that. Ok, good - could you also add a define for it, perhaps something like: #define GMU_IDLE_STATE_RESERVED 1 /* Cancelled feature, never exposed by fw */ Konrad