dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Dave Airlie <airlied@gmail.com>,
	dri-devel@lists.freedesktop.org,  tj@kernel.org,
	christian.koenig@amd.com, Johannes Weiner <hannes@cmpxchg.org>,
	 Michal Hocko <mhocko@kernel.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Shakeel Butt	 <shakeel.butt@linux.dev>,
	Muchun Song <muchun.song@linux.dev>
Cc: cgroups@vger.kernel.org, Waiman Long <longman@redhat.com>,
	simona@ffwll.ch, 	intel-xe@lists.freedesktop.org
Subject: Re: drm/ttm/memcg/lru: enable memcg tracking for ttm, xe and amdgpu driver (part 2) (v2).
Date: Wed, 22 Jul 2026 16:34:51 +0200	[thread overview]
Message-ID: <02ba25604e746fefa1a0ba54a76ad486154954ef.camel@linux.intel.com> (raw)
In-Reply-To: <20260706052330.1110909-1-airlied@gmail.com>

Hi, Dave,

On Mon, 2026-07-06 at 15:22 +1000, Dave Airlie wrote:
> This is just a repost with a number of sashiko identified problems
> that I fixed.
> 
> I committed the vmstat counters and list lru changes, and they are
> now in tree.
> 
> This is the remainder of this series. Intel have expressed interest
> in getting
> this landed for xe, we can drop the amdgpu changes for now if they
> can't get
> across the line.
> 
> I've dropped all previous acks/reviews.
> 
> This series adds the memcg counters for GPU active and GPU reclaim to
> align
> with the two global vmstats. It adds an accounting flag to TTM
> alloc/populate,
> and enables memcg tracking and shrinker support in TTM.
> 
> Then it adds amdgpu and xe support.
> 
> I think for this to land, Christian holds the main objection which I
> still fail
> to fully understand beyond it doesn't solve all the problems we ever
> have had
> with cgroups and drm, so we shouldn't even bother, and maybe we could
> do it at
> the object level, and integrated with dmem, and android cross process
> accounting,
> but I still feel this is a good baseline.
> 
> I think this is the right layer to hook this into TTM, where we
> allocate memory
> and I think accounting for this memory in a proper way should be
> done.
> 
> Intel folks (Thomas/Maarten) please review and express concerns as
> well.

Some questions about the design that might belong in the cover-letter.

- First, Since from my understanding gpu shmem allocations are charged
against memcg, (i915 igfx and to some extent dgfx), I think this makes
sense, although it would be good to have an outlook:

1) What about system memory allocations targeting suspend / hibernate
evictions, will they be charged against the root cgroup?

2) Plan for limits on total gpu pages / pinned gpu pages? Is dmemcg a
fit for such limits (coexisting with memcg) or should such limits be
implemented in memcg?

3) IIRC I noticed a patch for dma-heaps where dmemcg was suggested for
android, since it separates GPU memory and system memory. Do we plan
simething similar here, based on config options?

Thanks,
Thomas


> 
> Regards,
> Dave.

      parent reply	other threads:[~2026-07-22 14:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06  5:22 drm/ttm/memcg/lru: enable memcg tracking for ttm, xe and amdgpu driver (part 2) (v2) Dave Airlie
2026-07-06  5:22 ` [PATCH 01/10] memcg: add support for GPU page counters. (v5) Dave Airlie
2026-07-06  5:43   ` sashiko-bot
2026-07-22 14:38   ` Thomas Hellström
2026-07-06  5:22 ` [PATCH 02/10] ttm: add a memcg accounting flag to the alloc/populate APIs Dave Airlie
2026-07-06  5:35   ` sashiko-bot
2026-07-06 16:24   ` Matthew Brost
2026-07-22 15:08   ` Thomas Hellström
2026-07-06  5:22 ` [PATCH 03/10] ttm/pool: initialise the shrinker earlier (v2) Dave Airlie
2026-07-06  5:33   ` sashiko-bot
2026-07-22 15:33   ` Thomas Hellström
2026-07-06  5:22 ` [PATCH 04/10] ttm: add objcg pointer to bo and tt (v3) Dave Airlie
2026-07-06  5:34   ` sashiko-bot
2026-07-06  5:22 ` [PATCH 05/10] ttm/pool: enable memcg tracking and shrinker. (v3) Dave Airlie
2026-07-06  5:44   ` sashiko-bot
2026-09-24 15:08   ` Pranjal Arya
2026-07-06  5:22 ` [PATCH 06/10] ttm: hook up memcg placement flags Dave Airlie
2026-07-06  5:36   ` sashiko-bot
2026-07-06  5:22 ` [PATCH 07/10] memcontrol: allow objcg api when memcg is config off Dave Airlie
2026-07-06  5:22 ` [PATCH 08/10] amdgpu: add support for memory cgroups Dave Airlie
2026-07-06  5:41   ` sashiko-bot
2026-07-06  5:22 ` [PATCH 09/10] ttm: add support for a module option to disable memcg integration Dave Airlie
2026-07-06  5:39   ` sashiko-bot
2026-07-06  5:22 ` [PATCH 10/10] xe: create a flag to enable memcg accounting for XE as well Dave Airlie
2026-07-06  5:50   ` sashiko-bot
2026-07-06  7:55 ` drm/ttm/memcg/lru: enable memcg tracking for ttm, xe and amdgpu driver (part 2) (v2) Dave Airlie
2026-07-06 14:28   ` Thomas Hellström
2026-07-22 14:34 ` Thomas Hellström [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02ba25604e746fefa1a0ba54a76ad486154954ef.camel@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hannes@cmpxchg.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=longman@redhat.com \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=simona@ffwll.ch \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox