From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Marek Szyprowski' <m.szyprowski@samsung.com>,
'Jingoo Han' <jg1.han@samsung.com>,
'Leela Krishna Amudala' <l.krishna@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
ben-linux@fluff.org, inki.dae@samsung.com, joshi@samsung.com
Subject: RE: [PATCH 1/3] Move FIMD register headers to include/video/
Date: Wed, 01 Aug 2012 10:56:26 +0900 [thread overview]
Message-ID: <02ed01cd6f88$dc91caf0$95b560d0$%kim@samsung.com> (raw)
In-Reply-To: <033c01cd6ef6$fb514570$f1f3d050$%szyprowski@samsung.com>
Marek Szyprowski wrote:
>
> Hello,
>
Hi all,
[...]
> > static struct s3c_fb_driverdata s3c_fb_data_exynos5 = {
> > .variant = {
> > .nr_windows = 5,
> > - .vidtcon = VIDTCON0,
> > + .vidtcon = FIMD_V8_VIDTCON0,
>
> Yes, this method looks good imo. Maybe even having something like
> vidtcon_base in
> variant structure will be enough to cover all VIDTCON0-3 registers.
>
Yes, I agree. And how about changing the name of s3c_fb_drvierdata to
xxx_fimd_v8 not xxx_fimd_exynos5? It's time to use independent from SoC name
because we don't have any guarantee of same address on all of EXYNOS5 SoCs.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-08-01 1:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 8:45 [PATCH 0/3] ARM: SAMSUNG: Move FIMD headers to include/video/ Leela Krishna Amudala
2012-07-30 8:45 ` [PATCH 1/3] Move FIMD register " Leela Krishna Amudala
2012-07-30 8:46 ` Leela Krishna Amudala
2012-07-30 8:49 ` Sylwester Nawrocki
2012-07-30 11:05 ` Leela Krishna Amudala
2012-07-30 8:53 ` Jingoo Han
2012-07-30 9:09 ` Sylwester Nawrocki
2012-07-30 11:16 ` Leela Krishna Amudala
2012-07-30 14:32 ` Tomasz Figa
2012-07-31 0:47 ` Jingoo Han
2012-07-31 6:28 ` Marek Szyprowski
2012-07-31 7:12 ` Leela Krishna Amudala
2012-07-31 8:19 ` Jingoo Han
2012-07-31 8:32 ` Marek Szyprowski
2012-08-01 1:56 ` Kukjin Kim [this message]
2012-07-31 6:37 ` Tomasz Figa
2012-07-31 8:09 ` Jingoo Han
2012-08-01 1:50 ` Kukjin Kim
2012-08-01 1:46 ` Kukjin Kim
2012-07-30 8:45 ` [PATCH 2/3] arm: samsung: Include the modified FIMD header file Leela Krishna Amudala
2012-07-30 8:47 ` Leela Krishna Amudala
2012-07-30 8:45 ` [PATCH 3/3] driver: " Leela Krishna Amudala
2012-07-30 8:48 ` Leela Krishna Amudala
2012-07-30 8:45 ` [PATCH 0/3] ARM: SAMSUNG: Move FIMD headers to include/video/ Leela Krishna Amudala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02ed01cd6f88$dc91caf0$95b560d0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jg1.han@samsung.com \
--cc=joshi@samsung.com \
--cc=l.krishna@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox