From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: RE: [PATCH 1/1] drm/exynos: Fix build error with exynos_drm_connector.c Date: Fri, 30 Aug 2013 19:00:20 +0900 Message-ID: <02f601cea567$bc888080$35998180$%dae@samsung.com> References: <1377853851-32636-1-git-send-email-sachin.kamat@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id A9CDDE7CF5 for ; Fri, 30 Aug 2013 03:00:23 -0700 (PDT) Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MSC00K4X94LWJJ0@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 30 Aug 2013 19:00:21 +0900 (KST) In-reply-to: <1377853851-32636-1-git-send-email-sachin.kamat@linaro.org> Content-language: ko List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: 'Sachin Kamat' , dri-devel@lists.freedesktop.org Cc: 'Andrzej Hajda' , patches@linaro.org List-Id: dri-devel@lists.freedesktop.org > -----Original Message----- > From: Sachin Kamat [mailto:sachin.kamat@linaro.org] > Sent: Friday, August 30, 2013 6:11 PM > To: dri-devel@lists.freedesktop.org > Cc: inki.dae@samsung.com; sachin.kamat@linaro.org; patches@linaro.org; > Andrzej Hajda > Subject: [PATCH 1/1] drm/exynos: Fix build error with > exynos_drm_connector.c > > exynos_drm_connector.c now uses videomode helper API. Hence select > VIDEOMODE_HELPERS at DRM_EXYNOS level itself instead of at > DRM_EXYNOS_FIMD to avoid the following compilation error when FIMD > is not selected (introduced by commit cf796235a6 "drm/exynos: fimd: > replace struct fb_videomode with videomode"): > drivers/built-in.o: In function `exynos_drm_connector_get_modes': > drivers/gpu/drm/exynos/exynos_drm_connector.c:86: > undefined reference to `drm_display_mode_from_videomode' Applied. Thanks, Inki Dae > > Signed-off-by: Sachin Kamat > Cc: Andrzej Hajda > --- > drivers/gpu/drm/exynos/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/Kconfig > b/drivers/gpu/drm/exynos/Kconfig > index 80a251a..4752f22 100644 > --- a/drivers/gpu/drm/exynos/Kconfig > +++ b/drivers/gpu/drm/exynos/Kconfig > @@ -6,6 +6,7 @@ config DRM_EXYNOS > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT > select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE > + select VIDEOMODE_HELPERS > help > Choose this option if you have a Samsung SoC EXYNOS chipset. > If M is selected the module will be called exynosdrm. > @@ -26,7 +27,6 @@ config DRM_EXYNOS_FIMD > bool "Exynos DRM FIMD" > depends on DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM > select FB_MODE_HELPERS > - select VIDEOMODE_HELPERS > help > Choose this option if you want to use Exynos FIMD for DRM. > > -- > 1.7.9.5