From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: RE: [PATCH v3 21/32] drm/exynos: Move dp driver from video/ to drm/ Date: Thu, 31 Oct 2013 19:46:42 +0900 Message-ID: <031801ced626$7cca5820$765f0860$%dae@samsung.com> References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org> <1383063198-10526-22-git-send-email-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTP id BCAE5EE6AE for ; Thu, 31 Oct 2013 03:46:46 -0700 (PDT) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MVJ00B9H4LKHL30@mailout3.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 31 Oct 2013 19:46:45 +0900 (KST) In-reply-to: <1383063198-10526-22-git-send-email-seanpaul@chromium.org> Content-language: ko List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: 'Sean Paul' , dri-devel@lists.freedesktop.org Cc: marcheu@chromium.org, 'Jingoo Han' List-Id: dri-devel@lists.freedesktop.org CCing Jingoo, Is that ok to remove eDP driver from video/exynos? Isn't this driver really used by Linux framebuffer driver, s3c-fb.c? Of course, now s3c-fb driver is dead code because this driver doesn't support device tree yet but we would need more reviews and discussions about moving this driver into drm side. Let's watch new rules for device tree bindings of DRM world. So I'd not like to merge this driver yet. Thanks, Inki Dae > -----Original Message----- > From: Sean Paul [mailto:seanpaul@chromium.org] > Sent: Wednesday, October 30, 2013 1:13 AM > To: dri-devel@lists.freedesktop.org; inki.dae@samsung.com > Cc: airlied@linux.ie; tomasz.figa@gmail.com; marcheu@chromium.org; Sean > Paul > Subject: [PATCH v3 21/32] drm/exynos: Move dp driver from video/ to drm/ > > This patch moves the code from video/ to drm/ > > Signed-off-by: Sean Paul > --- > > Changes in v2: None > Changes in v3: None > > drivers/gpu/drm/exynos/Kconfig | 7 + > drivers/gpu/drm/exynos/Makefile | 1 + > drivers/gpu/drm/exynos/exynos_dp_core.c | 1213 > ++++++++++++++++++++++++++++++ > drivers/gpu/drm/exynos/exynos_dp_core.h | 210 ++++++ > drivers/gpu/drm/exynos/exynos_dp_reg.c | 1245 > +++++++++++++++++++++++++++++++ > drivers/gpu/drm/exynos/exynos_dp_reg.h | 366 +++++++++ > drivers/video/exynos/Kconfig | 7 - > drivers/video/exynos/Makefile | 1 - > drivers/video/exynos/exynos_dp_core.c | 1213 --------------------------- > --- > drivers/video/exynos/exynos_dp_core.h | 210 ------ > drivers/video/exynos/exynos_dp_reg.c | 1245 --------------------------- > ---- > drivers/video/exynos/exynos_dp_reg.h | 366 --------- > 12 files changed, 3042 insertions(+), 3042 deletions(-) > create mode 100644 drivers/gpu/drm/exynos/exynos_dp_core.c > create mode 100644 drivers/gpu/drm/exynos/exynos_dp_core.h > create mode 100644 drivers/gpu/drm/exynos/exynos_dp_reg.c > create mode 100644 drivers/gpu/drm/exynos/exynos_dp_reg.h > delete mode 100644 drivers/video/exynos/exynos_dp_core.c > delete mode 100644 drivers/video/exynos/exynos_dp_core.h > delete mode 100644 drivers/video/exynos/exynos_dp_reg.c > delete mode 100644 drivers/video/exynos/exynos_dp_reg.h > > diff --git a/drivers/gpu/drm/exynos/Kconfig > b/drivers/gpu/drm/exynos/Kconfig > index 45b6ef5..3ace74f 100644 > --- a/drivers/gpu/drm/exynos/Kconfig > +++ b/drivers/gpu/drm/exynos/Kconfig > @@ -30,6 +30,13 @@ config DRM_EXYNOS_FIMD > help > Choose this option if you want to use Exynos FIMD for DRM. > > +config DRM_EXYNOS_DP > + bool "EXYNOS DRM DP driver support" > + depends on ARCH_EXYNOS > + default n > + help > + This enables support for DP device. > + > config DRM_EXYNOS_HDMI > bool "Exynos DRM HDMI" > depends on DRM_EXYNOS && !VIDEO_SAMSUNG_S5P_TV > diff --git a/drivers/gpu/drm/exynos/Makefile > b/drivers/gpu/drm/exynos/Makefile > index afbe499..fc8555c 100644 > --- a/drivers/gpu/drm/exynos/Makefile > +++ b/drivers/gpu/drm/exynos/Makefile > @@ -11,6 +11,7 @@ exynosdrm-y := exynos_drm_drv.o exynos_drm_encoder.o > exynos_drm_connector.o \ > exynosdrm-$(CONFIG_DRM_EXYNOS_IOMMU) += exynos_drm_iommu.o > exynosdrm-$(CONFIG_DRM_EXYNOS_DMABUF) += exynos_drm_dmabuf.o > exynosdrm-$(CONFIG_DRM_EXYNOS_FIMD) += exynos_drm_fimd.o > +exynosdrm-$(CONFIG_DRM_EXYNOS_DP) += exynos_dp_core.o > exynos_dp_reg.o > exynosdrm-$(CONFIG_DRM_EXYNOS_HDMI) += exynos_hdmi.o exynos_mixer.o > exynosdrm-$(CONFIG_DRM_EXYNOS_VIDI) += exynos_drm_vidi.o > exynosdrm-$(CONFIG_DRM_EXYNOS_G2D) += exynos_drm_g2d.o > diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c > b/drivers/gpu/drm/exynos/exynos_dp_core.c > new file mode 100644 > index 0000000..089ae22 > --- /dev/null > +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c > @@ -0,0 +1,1213 @@ > +/* > + * Samsung SoC DP (Display Port) interface driver. > + * > + * Copyright (C) 2012 Samsung Electronics Co., Ltd. > + * Author: Jingoo Han > + * > + * This program is free software; you can redistribute it and/or modify > it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 2 of the License, or (at your > + * option) any later version. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include