From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH v3 1/3] video: smscufx: Less checks in ufx_usb_probe() after error detection Date: Sun, 7 Jan 2018 17:02:21 +0100 Message-ID: <03be4276-520e-1d22-1c6e-e35c8df2b1e8@users.sourceforge.net> References: <1736749.UIs06O4xc5@amdc3058> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mout.web.de (mout.web.de [212.227.15.4]) by gabe.freedesktop.org (Postfix) with ESMTPS id D14FC6E520 for ; Sun, 7 Jan 2018 16:02:29 +0000 (UTC) In-Reply-To: Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Steve Glendinning Cc: kernel-janitors@vger.kernel.org, LKML List-Id: dri-devel@lists.freedesktop.org RnJvbTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0PgpEYXRl OiBTdW4sIDcgSmFuIDIwMTggMTU6NTY6MTEgKzAxMDAKClVwIHRvIGZvdXIgY2hlY2tzIGNvdWxk IGJlIHJlcGVhdGVkIGJ5IHRoZSB1ZnhfdXNiX3Byb2JlKCkgZnVuY3Rpb24KZHVyaW5nIGVycm9y IGhhbmRsaW5nIGV2ZW4gaWYgdGhlIHJlbGV2YW50IHByb3BlcnRpZXMgY2FuIGJlIGRldGVybWlu ZWQKZm9yIHRoZSBpbnZvbHZlZCB2YXJpYWJsZXMgYmVmb3JlIGJ5IHNvdXJjZSBjb2RlIGFuYWx5 c2lzLgoKKiBSZXR1cm4gZGlyZWN0bHkgYWZ0ZXIgYSBjYWxsIG9mIHRoZSBmdW5jdGlvbiAia3ph bGxvYyIgZmFpbGVkCiAgYXQgdGhlIGJlZ2lubmluZy4KCiogQWRqdXN0IGp1bXAgdGFyZ2V0cyBz byB0aGF0IGV4dHJhIGNoZWNrcyBjYW4gYmUgb21pdHRlZCBhdCB0aGUgZW5kLgoKKiBEZWxldGUg aW5pdGlhbGlzYXRpb25zIGZvciB0aGUgdmFyaWFibGVzICJpbmZvIiBhbmQgInJldHZhbCIKICB3 aGljaCBiZWNhbWUgdW5uZWNlc3Nhcnkgd2l0aCB0aGlzIHJlZmFjdG9yaW5nLgoKU2lnbmVkLW9m Zi1ieTogTWFya3VzIEVsZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0PgotLS0K CnYzOgpUaGlzIHVwZGF0ZSBzdWdnZXN0aW9uIHdhcyByZWJhc2VkIG9uIHNvdXJjZSBmaWxlcyBm cm9tIHRoZSBzb2Z0d2FyZQoiTGludXggbmV4dC0yMDE4MDEwNSIuCgp2MjoKQSBjYWxsIG9mIHRo ZSBmdW5jdGlvbiAiZmJfZGVhbGxvY19jbWFwIiB3YXMgcHJlc2VydmVkIGZvciB0aGUgZXhjZXB0 aW9uCmhhbmRsaW5nIGF0IHRoZSBlbmQuCgogZHJpdmVycy92aWRlby9mYmRldi9zbXNjdWZ4LmMg fCA0NiArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMjcgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv ZHJpdmVycy92aWRlby9mYmRldi9zbXNjdWZ4LmMgYi9kcml2ZXJzL3ZpZGVvL2ZiZGV2L3Ntc2N1 ZnguYwppbmRleCA4ZGI3MDg1ZTVkMWEuLjg5M2RhZWIxZmZkOSAxMDA2NDQKLS0tIGEvZHJpdmVy cy92aWRlby9mYmRldi9zbXNjdWZ4LmMKKysrIGIvZHJpdmVycy92aWRlby9mYmRldi9zbXNjdWZ4 LmMKQEAgLTE2MjAsOCArMTYyMCw4IEBAIHN0YXRpYyBpbnQgdWZ4X3VzYl9wcm9iZShzdHJ1Y3Qg dXNiX2ludGVyZmFjZSAqaW50ZXJmYWNlLAogewogCXN0cnVjdCB1c2JfZGV2aWNlICp1c2JkZXY7 CiAJc3RydWN0IHVmeF9kYXRhICpkZXY7Ci0Jc3RydWN0IGZiX2luZm8gKmluZm8gPSBOVUxMOwot CWludCByZXR2YWwgPSAtRU5PTUVNOworCXN0cnVjdCBmYl9pbmZvICppbmZvOworCWludCByZXR2 YWw7CiAJdTMyIGlkX3JldiwgZnBnYV9yZXY7CiAKIAkvKiB1c2IgaW5pdGlhbGl6YXRpb24gKi8K QEAgLTE2MzEsNyArMTYzMSw3IEBAIHN0YXRpYyBpbnQgdWZ4X3VzYl9wcm9iZShzdHJ1Y3QgdXNi X2ludGVyZmFjZSAqaW50ZXJmYWNlLAogCWRldiA9IGt6YWxsb2Moc2l6ZW9mKCpkZXYpLCBHRlBf S0VSTkVMKTsKIAlpZiAoZGV2ID09IE5VTEwpIHsKIAkJZGV2X2VycigmdXNiZGV2LT5kZXYsICJ1 ZnhfdXNiX3Byb2JlOiBmYWlsZWQgYWxsb2Mgb2YgZGV2IHN0cnVjdFxuIik7Ci0JCWdvdG8gZXJy b3I7CisJCXJldHVybiAtRU5PTUVNOwogCX0KIAogCS8qIHdlIG5lZWQgdG8gd2FpdCBmb3IgYm90 aCB1c2IgYW5kIGZiZGV2IHRvIHNwaW4gZG93biBvbiBkaXNjb25uZWN0ICovCkBAIC0xNjUyLDkg KzE2NTIsOCBAQCBzdGF0aWMgaW50IHVmeF91c2JfcHJvYmUoc3RydWN0IHVzYl9pbnRlcmZhY2Ug KmludGVyZmFjZSwKIAlkZXZfZGJnKGRldi0+Z2RldiwgImZiX2RlZmlvIGVuYWJsZT0lZFxuIiwg ZmJfZGVmaW8pOwogCiAJaWYgKCF1ZnhfYWxsb2NfdXJiX2xpc3QoZGV2LCBXUklURVNfSU5fRkxJ R0hULCBNQVhfVFJBTlNGRVIpKSB7Ci0JCXJldHZhbCA9IC1FTk9NRU07CiAJCWRldl9lcnIoZGV2 LT5nZGV2LCAidWZ4X2FsbG9jX3VyYl9saXN0IGZhaWxlZFxuIik7Ci0JCWdvdG8gZXJyb3I7CisJ CWdvdG8gZV9ub21lbTsKIAl9CiAKIAkvKiBXZSBkb24ndCByZWdpc3RlciBhIG5ldyBVU0IgY2xh c3MuIE91ciBjbGllbnQgaW50ZXJmYWNlIGlzIGZiZGV2ICovCkBAIC0xNjYyLDkgKzE2NjEsOCBA QCBzdGF0aWMgaW50IHVmeF91c2JfcHJvYmUoc3RydWN0IHVzYl9pbnRlcmZhY2UgKmludGVyZmFj ZSwKIAkvKiBhbGxvY2F0ZXMgZnJhbWVidWZmZXIgZHJpdmVyIHN0cnVjdHVyZSwgbm90IGZyYW1l YnVmZmVyIG1lbW9yeSAqLwogCWluZm8gPSBmcmFtZWJ1ZmZlcl9hbGxvYygwLCAmdXNiZGV2LT5k ZXYpOwogCWlmICghaW5mbykgewotCQlyZXR2YWwgPSAtRU5PTUVNOwogCQlkZXZfZXJyKGRldi0+ Z2RldiwgImZyYW1lYnVmZmVyX2FsbG9jIGZhaWxlZFxuIik7Ci0JCWdvdG8gZXJyb3I7CisJCWdv dG8gZV9ub21lbTsKIAl9CiAKIAlkZXYtPmluZm8gPSBpbmZvOwpAQCAtMTY3NSw3ICsxNjczLDcg QEAgc3RhdGljIGludCB1ZnhfdXNiX3Byb2JlKHN0cnVjdCB1c2JfaW50ZXJmYWNlICppbnRlcmZh Y2UsCiAJcmV0dmFsID0gZmJfYWxsb2NfY21hcCgmaW5mby0+Y21hcCwgMjU2LCAwKTsKIAlpZiAo cmV0dmFsIDwgMCkgewogCQlkZXZfZXJyKGRldi0+Z2RldiwgImZiX2FsbG9jX2NtYXAgZmFpbGVk ICV4XG4iLCByZXR2YWwpOwotCQlnb3RvIGVycm9yOworCQlnb3RvIGRlc3Ryb3lfbW9kZWRiOwog CX0KIAogCUlOSVRfREVMQVlFRF9XT1JLKCZkZXYtPmZyZWVfZnJhbWVidWZmZXJfd29yaywKQEAg LTE3MzYsMjYgKzE3MzQsMjAgQEAgc3RhdGljIGludCB1ZnhfdXNiX3Byb2JlKHN0cnVjdCB1c2Jf aW50ZXJmYWNlICppbnRlcmZhY2UsCiAJcmV0dXJuIDA7CiAKIGVycm9yOgotCWlmIChkZXYpIHsK LQkJaWYgKGluZm8pIHsKLQkJCWlmIChpbmZvLT5jbWFwLmxlbiAhPSAwKQotCQkJCWZiX2RlYWxs b2NfY21hcCgmaW5mby0+Y21hcCk7Ci0JCQlpZiAoaW5mby0+bW9uc3BlY3MubW9kZWRiKQotCQkJ CWZiX2Rlc3Ryb3lfbW9kZWRiKGluZm8tPm1vbnNwZWNzLm1vZGVkYik7Ci0JCQl2ZnJlZShpbmZv LT5zY3JlZW5fYmFzZSk7Ci0KLQkJCWZiX2Rlc3Ryb3lfbW9kZWxpc3QoJmluZm8tPm1vZGVsaXN0 KTsKLQotCQkJZnJhbWVidWZmZXJfcmVsZWFzZShpbmZvKTsKLQkJfQotCi0JCWtyZWZfcHV0KCZk ZXYtPmtyZWYsIHVmeF9mcmVlKTsgLyogcmVmIGZvciBmcmFtZWJ1ZmZlciAqLwotCQlrcmVmX3B1 dCgmZGV2LT5rcmVmLCB1ZnhfZnJlZSk7IC8qIGxhc3QgcmVmIGZyb20ga3JlZl9pbml0ICovCi0K LQkJLyogZGV2IGhhcyBiZWVuIGRlYWxsb2NhdGVkLiBEbyBub3QgZGVyZWZlcmVuY2UgKi8KLQl9 Ci0KKwlmYl9kZWFsbG9jX2NtYXAoJmluZm8tPmNtYXApOworZGVzdHJveV9tb2RlZGI6CisJZmJf ZGVzdHJveV9tb2RlZGIoaW5mby0+bW9uc3BlY3MubW9kZWRiKTsKKwl2ZnJlZShpbmZvLT5zY3Jl ZW5fYmFzZSk7CisJZmJfZGVzdHJveV9tb2RlbGlzdCgmaW5mby0+bW9kZWxpc3QpOworCWZyYW1l YnVmZmVyX3JlbGVhc2UoaW5mbyk7CitwdXRfcmVmOgorCWtyZWZfcHV0KCZkZXYtPmtyZWYsIHVm eF9mcmVlKTsgLyogcmVmIGZvciBmcmFtZWJ1ZmZlciAqLworCWtyZWZfcHV0KCZkZXYtPmtyZWYs IHVmeF9mcmVlKTsgLyogbGFzdCByZWYgZnJvbSBrcmVmX2luaXQgKi8KIAlyZXR1cm4gcmV0dmFs OworCitlX25vbWVtOgorCXJldHZhbCA9IC1FTk9NRU07CisJZ290byBwdXRfcmVmOwogfQogCiBz dGF0aWMgdm9pZCB1ZnhfdXNiX2Rpc2Nvbm5lY3Qoc3RydWN0IHVzYl9pbnRlcmZhY2UgKmludGVy ZmFjZSkKLS0gCjIuMTUuMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==