Re: [PATCH v2 2/2] drm/gem: Implement shadow-plane {begin,end}_fb_access with vmap

[Javier Martinez Canillas <javierm@redhat.com>]

On 10/25/22 12:17, Thomas Zimmermann wrote:
> Move the vmap code for shadow-plane helpers from prepare_fb to
> begin_fb_access helpers. Vunmap is now performed at the end of
> the current pageflip, instead of the end of the following pageflip.
> 
> Reduces the duration of the mapping from while the framebuffer is
> being displayed to just the atomic commit. This is safe as outside
> of the pageflip, nothing should access the mapped buffer memory.
> Unmapping the framebuffer BO memory early allows reduces address-space

"allows to reduce" or "allows a reduced" ?

> consumption and possibly allows for evicting the memory pages.
> 
> The change is effectively a rename of prepare_fb and cleanup_fb
> implementations, plus updates to the shadow-plane init macro. As
> there's no longer a prepare_fb helper for shadow planes, atomic
> helpers will call drm_gem_plane_helper_prepare_fb() automatically.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat