From: Javier Martinez Canillas <javierm@redhat.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-fbdev@vger.kernel.org, "David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Noralf Trønnes" <noralf@tronnes.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Maxime Ripard" <maxime@cerno.tech>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 1/4] drm: Add I2C connector type
Date: Tue, 1 Feb 2022 00:26:22 +0100 [thread overview]
Message-ID: <03ffaaa6-1a8c-68fa-dd17-1e6d0e1e4868@redhat.com> (raw)
In-Reply-To: <YfhMESTylI1NTKDg@ravnborg.org>
On 1/31/22 21:52, Sam Ravnborg wrote:
> On Mon, Jan 31, 2022 at 09:12:21PM +0100, Javier Martinez Canillas wrote:
>> There isn't a connector type for display controllers accesed through I2C,
>> most drivers use DRM_MODE_CONNECTOR_Unknown or DRM_MODE_CONNECTOR_VIRTUAL.
>>
>> Add an I2C connector type to match the actual connector.
>>
>> As Noralf Trønnes mentions in commit fc06bf1d76d6 ("drm: Add SPI connector
>> type"), user-space should be able to cope with a connector type that does
>> not yet understand.
>>
>> Tested with `modetest -M ssd1307 -c` and shows the connector as unknown-1.
> I had expected unknown-21??
>
As you pointed out in patch 3/4, I forgot to change DRM_MODE_CONNECTOR_Unknown
to DRM_MODE_CONNECTOR_I2C after adding this patch...
>>
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
>> ---
Thanks!
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2022-01-31 23:26 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 20:12 [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Javier Martinez Canillas
2022-01-31 20:12 ` [PATCH 1/4] drm: Add I2C connector type Javier Martinez Canillas
2022-01-31 20:52 ` Sam Ravnborg
2022-01-31 23:26 ` Javier Martinez Canillas [this message]
2022-02-01 12:58 ` Noralf Trønnes
2022-02-01 13:06 ` Javier Martinez Canillas
2022-02-01 13:20 ` Noralf Trønnes
2022-02-01 13:55 ` Javier Martinez Canillas
2022-02-01 13:38 ` Simon Ser
2022-02-01 14:20 ` Noralf Trønnes
2022-02-01 20:57 ` Sam Ravnborg
2022-02-01 22:29 ` Simon Ser
2022-02-02 8:46 ` Javier Martinez Canillas
2022-02-02 9:14 ` Thomas Zimmermann
2022-02-02 9:45 ` Noralf Trønnes
2022-02-02 15:04 ` Pekka Paalanen
2022-02-02 16:00 ` Noralf Trønnes
2022-01-31 20:12 ` [PATCH 2/4] drm/format-helper: Add drm_fb_gray8_to_mono_reversed() Javier Martinez Canillas
2022-02-01 9:59 ` Thomas Zimmermann
2022-02-01 11:13 ` Pekka Paalanen
2022-02-01 11:48 ` Javier Martinez Canillas
2022-03-14 13:40 ` Geert Uytterhoeven
2022-03-14 14:07 ` Javier Martinez Canillas
2022-01-31 20:36 ` [PATCH 0/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Simon Ser
2022-01-31 20:39 ` Simon Ser
2022-01-31 23:21 ` Javier Martinez Canillas
2022-02-01 8:26 ` Geert Uytterhoeven
2022-02-01 8:34 ` Simon Ser
2022-02-01 8:36 ` Geert Uytterhoeven
2022-02-01 10:08 ` Thomas Zimmermann
2022-02-01 10:11 ` Simon Ser
2022-02-01 10:17 ` Thomas Zimmermann
2022-02-01 8:38 ` Daniel Vetter
2022-02-01 9:49 ` Javier Martinez Canillas
2022-02-01 10:42 ` Pekka Paalanen
2022-02-01 11:07 ` Geert Uytterhoeven
2022-02-02 9:19 ` Pekka Paalanen
2022-02-02 10:55 ` Geert Uytterhoeven
2022-01-31 20:56 ` Sam Ravnborg
2022-01-31 23:37 ` Javier Martinez Canillas
2022-02-01 9:37 ` Andy Shevchenko
2022-02-01 11:31 ` Javier Martinez Canillas
2022-02-01 11:38 ` Geert Uytterhoeven
2022-02-01 13:09 ` Javier Martinez Canillas
2022-02-01 14:14 ` Geert Uytterhoeven
2022-02-01 15:03 ` Javier Martinez Canillas
2022-02-01 20:40 ` Sam Ravnborg
2022-02-02 8:38 ` Javier Martinez Canillas
2022-02-02 11:06 ` Andy Shevchenko
2022-02-02 11:39 ` Javier Martinez Canillas
2022-02-02 11:50 ` Andy Shevchenko
2022-02-02 11:54 ` Javier Martinez Canillas
2022-02-02 12:21 ` Andy Shevchenko
2022-02-01 8:43 ` Geert Uytterhoeven
2022-02-01 9:27 ` Simon Ser
2022-02-01 10:36 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03ffaaa6-1a8c-68fa-dd17-1e6d0e1e4868@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=andriy.shevchenko@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=noralf@tronnes.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).