From: "Agrawal, Akshu" <Akshu.Agrawal-5C7GfCeVMHo@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Alex Deucher
<alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
tiwai-l3A5Bk7waGM@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Vijendar.Mukunda-5C7GfCeVMHo@public.gmane.org,
Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
Bard Liao <bardliao-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH v2 2/3] ASoC: rt5645: Wait for 400msec before concluding on value of RT5645_VENDOR_ID2
Date: Thu, 9 Nov 2017 14:44:59 +0530 [thread overview]
Message-ID: <042f85a6-2fa8-2a2f-1733-fd57f807722b@amd.com> (raw)
In-Reply-To: <20171108180957.ddcdyzu2fschypbx-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
On 11/8/2017 11:39 PM, Mark Brown wrote:
> On Wed, Nov 08, 2017 at 12:24:03PM -0500, Alex Deucher wrote:
>
>> regmap_read(regmap, RT5645_VENDOR_ID2, &val);
>>
>> + /*
>> + * Read after 400msec, as it is the interval required between
>> + * read and power On.
>> + */
>> + msleep(TIME_TO_POWER_MS);
>> + regmap_read(regmap, RT5645_VENDOR_ID2, &val);
>> +
>
> This leaves the original read in there so we've both got the early read
> (which might upset things potentially) and the delayed read. Shouldn't
> we just be adding a msleep() before the existing read?
>
My bad, I should have removed the addition of register read from the patch.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2017-11-09 9:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 17:24 [PATCH v2 0/3] Fixes for AMD Stoney ACP audio Alex Deucher
[not found] ` <20171108172404.19118-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-11-08 17:24 ` [PATCH 1/3] ASoC: AMD: Make the driver name consistent across files Alex Deucher
2017-11-08 18:08 ` Mark Brown
2017-11-08 18:12 ` Deucher, Alexander
2017-11-08 18:34 ` Mark Brown
2017-11-08 17:24 ` [PATCH 3/3] FIXUP: FROMLIST: ASoC: amd: Report accurate hw_ptr during dma Alex Deucher
[not found] ` <20171108172404.19118-4-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-11-08 17:29 ` Guenter Roeck
[not found] ` <CABXOdTdgxOFJb0B7VRivFaf1ihfKQWiyXRX9hFnKetTanmjd5w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-08 17:42 ` Alex Deucher
2017-11-08 17:45 ` Alex Deucher
2017-11-08 18:00 ` Mark Brown
2017-11-08 21:43 ` Applied "ASoC: amd: use do_div rather than 64 bit division to fix 32 bit builds" to the asoc tree Mark Brown
2017-11-08 17:24 ` [PATCH v2 2/3] ASoC: rt5645: Wait for 400msec before concluding on value of RT5645_VENDOR_ID2 Alex Deucher
2017-11-08 18:09 ` Mark Brown
[not found] ` <20171108180957.ddcdyzu2fschypbx-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-11-09 9:14 ` Agrawal, Akshu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=042f85a6-2fa8-2a2f-1733-fd57f807722b@amd.com \
--to=akshu.agrawal-5c7gfcevmho@public.gmane.org \
--cc=Vijendar.Mukunda-5C7GfCeVMHo@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=bardliao-Rasf1IRRPZFBDgjK7y7TUQ@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tiwai-l3A5Bk7waGM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox