From: Marek Vasut <marex@denx.de>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm: simple_kms_helper: Handle the vblank events
Date: Tue, 4 Oct 2016 22:39:07 +0200 [thread overview]
Message-ID: <04bcb13a-ea01-b019-9459-1de89c0d03ce@denx.de> (raw)
In-Reply-To: <CAKMK7uHHo5GGT3oJL14YG+GnvAGEs_7fDnRV7LT_3EqR7ux9_g@mail.gmail.com>
On 10/03/2016 03:51 PM, Daniel Vetter wrote:
> On Sun, Oct 2, 2016 at 7:15 PM, Marek Vasut <marex@denx.de> wrote:
>>> One thing we could look into for simple pipe helpers is to have a
>>> drm_simple_pipe_state which contains both states, and pass that
>>> simple_state into all callbacks. Needs a bit of trickery in the
>>> atomic_duplicate_state hooks though, so not sure whether that's worth
>>> it. But merging plane/crtc state for simple pipe would be nice, since
>>> the plane/crtc itself are also merged.
>>
>> I took a brief look into this, but I don't think I see the benefit of
>> it. What am I missing here ?
>
> Well if there's no benefit, then let's not do it - it was just an idea I had.
But I'm a newcomer to DRM/KMS framework, most of the time I barely know
what I'm doing, so it's easily possible I missed something obvious. I
can only think of reducing the number of memory allocations a little,
but I am not convinced this is worth it.
> -Daniel
>
--
Best regards,
Marek Vasut
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-10-04 21:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 19:41 [PATCH] drm: simple_kms_helper: Handle the vblank events Marek Vasut
2016-09-25 21:00 ` Daniel Vetter
2016-09-26 9:41 ` Marek Vasut
2016-09-26 12:59 ` Marek Vasut
2016-09-27 7:49 ` Daniel Vetter
2016-09-27 10:29 ` Marek Vasut
2016-09-27 12:16 ` Noralf Trønnes
2016-09-27 12:20 ` Marek Vasut
2016-09-29 9:28 ` Daniel Vetter
2016-09-29 21:04 ` Marek Vasut
2016-09-30 9:50 ` Daniel Vetter
2016-10-02 17:15 ` Marek Vasut
2016-10-03 13:51 ` Daniel Vetter
2016-10-04 20:39 ` Marek Vasut [this message]
2016-09-27 7:50 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04bcb13a-ea01-b019-9459-1de89c0d03ce@denx.de \
--to=marex@denx.de \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).