* [PATCH] drm/panel: panel-samsung-s6e88a0-ams427ap24: Fix includes
@ 2025-08-12 8:25 Thomas Zimmermann
2025-08-18 9:01 ` Thomas Zimmermann
2025-08-18 16:19 ` neil.armstrong
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2025-08-12 8:25 UTC (permalink / raw)
To: neil.armstrong, jessica.zhang; +Cc: dri-devel, Thomas Zimmermann
Include <linux/property.h> to declare device_property_read_bool() and
<linux/mod_devicetable.h> to declare struct of_device_id. Avoids the
dependency on the backlight header to include both.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c b/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
index e91f50662997..7e2f4e043d62 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
@@ -7,7 +7,9 @@
#include <linux/backlight.h>
#include <linux/delay.h>
#include <linux/gpio/consumer.h>
+#include <linux/mod_devicetable.h>
#include <linux/module.h>
+#include <linux/property.h>
#include <linux/regulator/consumer.h>
#include <video/mipi_display.h>
--
2.50.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: panel-samsung-s6e88a0-ams427ap24: Fix includes
2025-08-12 8:25 [PATCH] drm/panel: panel-samsung-s6e88a0-ams427ap24: Fix includes Thomas Zimmermann
@ 2025-08-18 9:01 ` Thomas Zimmermann
2025-08-18 16:19 ` neil.armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2025-08-18 9:01 UTC (permalink / raw)
To: neil.armstrong, jessica.zhang; +Cc: dri-devel
ping for review
Am 12.08.25 um 10:25 schrieb Thomas Zimmermann:
> Include <linux/property.h> to declare device_property_read_bool() and
> <linux/mod_devicetable.h> to declare struct of_device_id. Avoids the
> dependency on the backlight header to include both.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c b/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
> index e91f50662997..7e2f4e043d62 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
> @@ -7,7 +7,9 @@
> #include <linux/backlight.h>
> #include <linux/delay.h>
> #include <linux/gpio/consumer.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> +#include <linux/property.h>
> #include <linux/regulator/consumer.h>
>
> #include <video/mipi_display.h>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panel: panel-samsung-s6e88a0-ams427ap24: Fix includes
2025-08-12 8:25 [PATCH] drm/panel: panel-samsung-s6e88a0-ams427ap24: Fix includes Thomas Zimmermann
2025-08-18 9:01 ` Thomas Zimmermann
@ 2025-08-18 16:19 ` neil.armstrong
1 sibling, 0 replies; 3+ messages in thread
From: neil.armstrong @ 2025-08-18 16:19 UTC (permalink / raw)
To: Thomas Zimmermann, jessica.zhang; +Cc: dri-devel
On 12/08/2025 10:25, Thomas Zimmermann wrote:
> Include <linux/property.h> to declare device_property_read_bool() and
> <linux/mod_devicetable.h> to declare struct of_device_id. Avoids the
> dependency on the backlight header to include both.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c b/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
> index e91f50662997..7e2f4e043d62 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c
> @@ -7,7 +7,9 @@
> #include <linux/backlight.h>
> #include <linux/delay.h>
> #include <linux/gpio/consumer.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> +#include <linux/property.h>
> #include <linux/regulator/consumer.h>
>
> #include <video/mipi_display.h>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-18 16:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-12 8:25 [PATCH] drm/panel: panel-samsung-s6e88a0-ams427ap24: Fix includes Thomas Zimmermann
2025-08-18 9:01 ` Thomas Zimmermann
2025-08-18 16:19 ` neil.armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).