From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Kleiner Subject: Re: [PATCH 1/3] drm: Defer disabling the vblank IRQ until the next interrupt (for instant-off) Date: Wed, 22 Mar 2017 16:06:32 +0100 Message-ID: <08524408-b648-7c67-9ea4-a8c58f92f424@gmail.com> References: <20170315204027.20160-1-chris@chris-wilson.co.uk> <20170315210031.GY31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170315210031.GY31595@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Chris Wilson Cc: =?UTF-8?Q?Michel_D=c3=a4nzer?= , dri-devel@lists.freedesktop.org, Laurent Pinchart , Dave Airlie , intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMDMvMTUvMjAxNyAxMDowMCBQTSwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+IE9uIFdlZCwg TWFyIDE1LCAyMDE3IGF0IDA4OjQwOjI1UE0gKzAwMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPj4g T24gdmJsYW5rIGluc3RhbnQtb2ZmIHN5c3RlbXMsIHdlIGNhbiBnZXQgaW50byBhIHNpdHVhdGlv biB3aGVyZSB0aGUgY29zdAo+PiBvZiBlbmFibGluZyBhbmQgZGlzYWJsaW5nIHRoZSB2Ymxhbmsg SVJRIGFyb3VuZCBhIGRybVdhaXRWYmxhbmsgcXVlcnkKPj4gZG9taW5hdGVzLiBBbmQgd2l0aCB0 aGUgYWR2ZW50IG9mIGV2ZW4gZGVlcGVyIGhhcmR3YXJlIHNsZWVwIHN0YXRlLAo+PiB0b3VjaGlu ZyByZWdpc3RlcnMgYmVjb21lcyBldmVyIG1vcmUgZXhwZW5zaXZlLiAgSG93ZXZlciwgd2Uga25v dyB0aGF0IGlmCj4+IHRoZSB1c2VyIHdhbnRzIHRoZSBjdXJyZW50IHZibGFuayBjb3VudGVyLCB0 aGV5IGFyZSBhbHNvIHZlcnkgbGlrZWx5IHRvCj4+IGltbWVkaWF0ZWx5IHF1ZXVlIGEgdmJsYW5r IHdhaXQgYW5kIHNvIHdlIGNhbiBrZWVwIHRoZSBpbnRlcnJ1cHQgYXJvdW5kCj4+IGFuZCBvbmx5 IHR1cm4gaXQgb2ZmIGlmIHdlIGhhdmUgbm8gZnVydGhlciB2YmxhbmsgcmVxdWVzdHMgcXVldWVk IHdpdGhpbgo+PiB0aGUgaW50ZXJydXB0IGludGVydmFsLgo+Pgo+PiBBZnRlciB2YmxhbmsgZXZl bnQgZGVsaXZlcnksIHRoaXMgcGF0Y2ggYWRkcyBhIHNoYWRvdyBvZiBvbmUgdmJsYW5rIHdoZXJl Cj4+IHRoZSBpbnRlcnJ1cHQgaXMga2VwdCBhbGl2ZSBmb3IgdGhlIHVzZXIgdG8gcXVlcnkgYW5k IHF1ZXVlIGFub3RoZXIgdmJsYW5rCj4+IGV2ZW50LiBTaW1pbGFybHksIGlmIHRoZSB1c2VyIGlz IHVzaW5nIGJsb2NraW5nIGRybVdhaXRWYmxhbmtzLCB0aGUKPj4gaW50ZXJydXB0IHdpbGwgYmUg ZGlzYWJsZWQgb24gdGhlIElSUSBmb2xsb3dpbmcgdGhlIHdhaXQgY29tcGxldGlvbi4KPj4gSG93 ZXZlciwgaWYgdGhlIHVzZXIgaXMgc2ltcGx5IHF1ZXJ5aW5nIHRoZSBjdXJyZW50IHZibGFuayBj b3VudGVyIGFuZAo+PiB0aW1lc3RhbXAsIHRoZSBpbnRlcnJ1cHQgd2lsbCBiZSBkaXNhYmxlZCBh ZnRlciBldmVyeSBJUlEgYW5kIHRoZSB1c2VyCj4+IHdpbGwgZW5hYmxlZCBpdCBhZ2FpbiBvbiB0 aGUgZmlyc3QgcXVlcnkgZm9sbG93aW5nIHRoZSBJUlEuCj4+Cj4+IHYyOiBNYXJpbyBLbGVpbmVy IC0KPj4gQWZ0ZXIgdGVzdGluZyB0aGlzLCBvbmUgbW9yZSB0aGluZyB0aGF0IHdvdWxkIG1ha2Ug c2Vuc2UgaXMgdG8gbW92ZQo+PiB0aGUgZGlzYWJsZSBibG9jayBhdCB0aGUgZW5kIG9mIGRybV9o YW5kbGVfdmJsYW5rKCkgaW5zdGVhZCBvZiBhdCB0aGUKPj4gdG9wLgo+Pgo+PiBUdXJucyBvdXQg dGhhdCBpZiBoaWdoIHByZWNpc2lvbiB0aW1lc3RhbWluZyBpcyBkaXNhYmxlZCBvciBkb2Vzbid0 Cj4+IHdvcmsgZm9yIHNvbWUgcmVhc29uIChhcyBjYW4gYmUgc2ltdWxhdGVkIGJ5IGVjaG8gMCA+ Cj4+IC9zeXMvbW9kdWxlL2RybS9wYXJhbWV0ZXJzL3RpbWVzdGFtcF9wcmVjaXNpb25fdXNlYyks IHRoZW4gd2l0aCB5b3VyCj4+IGRlbGF5ZWQgZGlzYWJsZSBjb2RlIGF0IGl0cyBjdXJyZW50IHBs YWNlLCB0aGUgdmJsYW5rIGNvdW50ZXIgd29uJ3QKPj4gaW5jcmVtZW50IGFueW1vcmUgYXQgYWxs IGZvciBpbnN0YW50IHF1ZXJpZXMsIGllLiB3aXRoIHlvdXIgb3RoZXIKPj4gImluc3RhbnQgcXVl cnkiIHBhdGNoZXMuIENsaWVudHMgd2hpY2ggcmVwZWF0ZWRseSBxdWVyeSB0aGUgY291bnRlcgo+ PiBhbmQgd2FpdCBmb3IgaXQgdG8gcHJvZ3Jlc3Mgd2lsbCBzaW1wbHkgaGFuZywgc3Bpbm5pbmcg aW4gYW4gZW5kbGVzcwo+PiBxdWVyeSBsb29wLiBUaGVyZSdzIHRoYXQgY29tbWVudCBpbiB2Ymxh bmtfZGlzYWJsZV9hbmRfc2F2ZToKPj4KPj4gIiogU2tpcCB0aGlzIHN0ZXAgaWYgdGhlcmUgaXNu J3QgYW55IGhpZ2ggcHJlY2lzaW9uIHRpbWVzdGFtcAo+PiAgKiBhdmFpbGFibGUuIEluIHRoYXQg Y2FzZSB3ZSBjYW4ndCBhY2NvdW50IGZvciB0aGlzIGFuZCBqdXN0Cj4+ICAqIGhvcGUgZm9yIHRo ZSBiZXN0Lgo+PiAgKi8KPj4KPj4gV2l0aCB0aGUgZGlzYWJsZSBoYXBwZW5pbmcgYWZ0ZXIgbGVh ZGluZyBlZGdlIG9mIHZibGFuayAoPT0gaHcgY291bnRlcgo+PiBpbmNyZW1lbnQgYWxyZWFkeSBo YXBwZW5lZCkgYnV0IGJlZm9yZSB0aGUgdmJsYW5rIGNvdW50ZXIvdGltZXN0YW1wCj4+IGhhbmRs aW5nIGluIGRybV9oYW5kbGVfdmJsYW5rLCB0aGF0IHN0ZXAgaXMgbmVlZGVkIHRvIGtlZXAgdGhl IGNvdW50ZXIKPj4gcHJvZ3Jlc3NpbmcsIHNvIHNraXBwaW5nIGl0IGlzIGJhZC4KPj4KPj4gTm93 IHdpdGhvdXQgaGlnaCBwcmVjaXNpb24gdGltZXN0YW1waW5nIHN1cHBvcnQsIGEga21zIGRyaXZl ciBtdXN0IG5vdAo+PiBzZXQgZGV2LT52YmxhbmtfZGlzYWJsZV9pbW1lZGlhdGUgPSB0cnVlLCBh cyB0aGlzIHdvdWxkIGNhdXNlIHByb2JsZW1zCj4+IGZvciBjbGllbnRzLCBzbyB0aGlzIHNob3Vs ZG4ndCBtYXR0ZXIsIGJ1dCBpdCB3b3VsZCBiZSBnb29kIHRvIHN0aWxsCj4+IG1ha2UgdGhpcyBy b2J1c3QgYWdhaW5zdCBhIGZ1dHVyZSBrbXMgZHJpdmVyIHdoaWNoIG1pZ2h0IGhhdmUKPj4gdW5y ZWxpYWJsZSBoaWdoIHByZWNpc2lvbiB0aW1lc3RhbXBpbmcsIGUuZy4sIGhpZ2ggcHJlY2lzaW9u Cj4+IHRpbWVzdGFtcGluZyB0aGF0IGludGVybWl0dGVudGx5IGRvZXNuJ3Qgd29yay4KPj4KPj4g djM6IFBhdGNoIGJlZm9yZSBjb2ZmZWUgbmVlZHMgZXh0cmEgY29mZmVlLgo+Pgo+PiBUZXN0Y2Fz ZTogaWd0L2ttc192YmxhbmsKPj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0Bj aHJpcy13aWxzb24uY28udWs+Cj4+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFA bGludXguaW50ZWwuY29tPgo+PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+ PiBDYzogTWljaGVsIETDpG56ZXIgPG1pY2hlbEBkYWVuemVyLm5ldD4KPj4gQ2M6IExhdXJlbnQg UGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KPj4gQ2M6IERhdmUg QWlybGllIDxhaXJsaWVkQHJlZGhhdC5jb20+LAo+PiBDYzogTWFyaW8gS2xlaW5lciA8bWFyaW8u a2xlaW5lci5kZUBnbWFpbC5jb20+Cj4KPiBZZXAuIFRoaXMgc2VlbXMgbGlrZSBhIGdvb2QgaWRl YSB0byBtZS4gSSBqdXN0IG5lZ2xlY3RlZCB0byByZXZpZXcgaXQKPiBsYXN0IHRpbWUgYXJvdW5k IChhbmQgbWF5YmUgZXZlbiBiZWZvcmUgdGhhdD8pIGZvciBzb21lIHJlYXNvbi4gTG9ja3MKPiBz ZWVtIHRvIGJlIHRha2VuIGluIHRoZSByaWdodCBvcmRlciwgc28gaXQgYXQgbGVhc3QgbG9va3Mg c2FmZSB0byBtZS4KPgo+IFJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgo+CgpIaSwKCmFzIGEgZm9sbG93dXAgdG8gdGhpcyBvbmUsIG1h eWJlIHdlIHNob3VsZCBtb3ZlIHRoZSAKZHJtX2hhbmRsZV92YmxhbmtfZXZlbnRzKGRldiwgcGlw ZSk7IGRvd24sIGltbWVkaWF0ZWx5IGFmdGVyIENocmlzIG5ldyAKZGVsYXllZCBkaXNhYmxlIGNv ZGU/CgpUaGUgaWRlYSB3YXMgdG8gYXZvaWQgbG90cyBvZiByZWR1bmRhbnQgZW5hYmxlLT5kaXNh YmxlLT5lbmFibGUuLi4gY2FsbHMgCmJ5IGhhdmluZyBzb21lIDEgZnJhbWUgZGVsYXkgYmVmb3Jl IGRpc2FibGUuIFRoaXMgd29ya3MgZm9yIHB1cmUgdmJsYW5rIApjb3VudC90cyBxdWVyaWVzLgoK QnV0IGJvdGggRFJJMiBhbmQgRFJJMy9QcmVzZW50IHVzZSB2YmxhbmsgZXZlbnRzIHRvIHRyaWdn ZXIgYSAKcGFnZWZsaXAtaW9jdGwgYXQgdGhlIHJpZ2h0IHRhcmdldCB2YmxhbmsuIFdpdGggdGhl IGN1cnJlbnQgb3JkZXJpbmcgd2UgCm1heSBkaXNwYXRjaCB0aGUgdmJsYW5rIHN3YXAgdHJpZ2dl ciBldmVudCB0byB0aGUgWC1TZXJ2ZXIgYW5kIGRyb3AgdGhlIAp2YmxhbmsgcmVmY291bnQgdG8g emVybyBkdWUgdG8gdGhlIHZibGFua19wdXQgaW5zaWRlIApkcm1faGFuZGxlX3ZibGFua19ldmVu dHMgZm9yIHRoZSBkaXNwYXRjaGVkIGV2ZW50LCB0aGVuIGRldGVjdCBpbiB0aGlzIApwYXRjaCB0 aGF0IHJlZmNvdW50ID09IDAgYW5kIGRpc2FibGUgdmJsYW5rcywgYnV0IGEgZmV3IG1pY3Jvc2Vj b25kcyAKbGF0ZXIgdGhlIHNlcnZlciB3aWxsIHF1ZXVlIGEgcGFnZWZsaXAgaW9jdGwgd2hpY2gg YnVtcHMgdGhlIHJlZmNvdW50IAphbmQgcmVlbmFibGVzIHZibGFuayBpcnFzLCBzbyB3ZSBoYXZl IGEgcmVkdW5kYW50IGRpc2FibGUtPmVuYWJsZS4KCkFsc28gbWFueSBrbXMgZHJpdmVycyBub3cg dXNlIGRybV9jcnRjX2FybV92YmxhbmtfZXZlbnQoKSBmb3IgcGFnZWZsaXAgCmNvbXBsZXRpb24g aGFuZGxpbmcgYXQgdmJsYW5rLCB0aGUgcGFnZWZsaXAgY29tcGxldGlvbiBldmVudHMgYXJlIGFs c28gCmRpc3BhdGNoZWQgdmlhIGRybV9oYW5kbGVfdmJsYW5rX2V2ZW50cygpLiBBZnRlciBhIHBh Z2VmbGlwIGNvbXBsZXRlcywgCml0IG1ha2VzIHNlbnNlIHRvIGhhdmUgdGhpcyAic3dhcCBzaGFk b3ciIG9mIDEgZnVsbCBmcmFtZSwgYXMgYW5pbWF0aW9ucyAKd291bGQgbGlrZWx5IHF1ZXVlIGEg bmV3IHZibGFuayBxdWVyeS9ldmVudCBpbW1lZGlhdGVseSBmb3IgdGhlIG5leHQgCmFuaW1hdGlv biBmcmFtZS4KCi1tYXJpbwoKPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2lycS5jIHwg MTQgKysrKysrKysrKysrLS0KPj4gIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAy IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9pcnEu YyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMKPj4gaW5kZXggOWJkY2E2OWY3NTRjLi5lNjRi MDVlYTk1ZWEgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMKPj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2RybV9pcnEuYwo+PiBAQCAtMTE5OCw5ICsxMTk4LDkgQEAgc3Rh dGljIHZvaWQgZHJtX3ZibGFua19wdXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQg aW50IHBpcGUpCj4+ICAJaWYgKGF0b21pY19kZWNfYW5kX3Rlc3QoJnZibGFuay0+cmVmY291bnQp KSB7Cj4+ICAJCWlmIChkcm1fdmJsYW5rX29mZmRlbGF5ID09IDApCj4+ICAJCQlyZXR1cm47Cj4+ IC0JCWVsc2UgaWYgKGRldi0+dmJsYW5rX2Rpc2FibGVfaW1tZWRpYXRlIHx8IGRybV92Ymxhbmtf b2ZmZGVsYXkgPCAwKQo+PiArCQllbHNlIGlmIChkcm1fdmJsYW5rX29mZmRlbGF5IDwgMCkKPj4g IAkJCXZibGFua19kaXNhYmxlX2ZuKCh1bnNpZ25lZCBsb25nKXZibGFuayk7Cj4+IC0JCWVsc2UK Pj4gKwkJZWxzZSBpZiAoIWRldi0+dmJsYW5rX2Rpc2FibGVfaW1tZWRpYXRlKQo+PiAgCQkJbW9k X3RpbWVyKCZ2YmxhbmstPmRpc2FibGVfdGltZXIsCj4+ICAJCQkJICBqaWZmaWVzICsgKChkcm1f dmJsYW5rX29mZmRlbGF5ICogSFopLzEwMDApKTsKPj4gIAl9Cj4+IEBAIC0xNzM0LDYgKzE3MzQs MTYgQEAgYm9vbCBkcm1faGFuZGxlX3ZibGFuayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNp Z25lZCBpbnQgcGlwZSkKPj4gIAl3YWtlX3VwKCZ2YmxhbmstPnF1ZXVlKTsKPj4gIAlkcm1faGFu ZGxlX3ZibGFua19ldmVudHMoZGV2LCBwaXBlKTsKPj4KPj4gKwkvKiBXaXRoIGluc3RhbnQtb2Zm LCB3ZSBkZWZlciBkaXNhYmxpbmcgdGhlIGludGVycnVwdCB1bnRpbCBhZnRlcgo+PiArCSAqIHdl IGZpbmlzaCBwcm9jZXNzaW5nIHRoZSBmb2xsb3dpbmcgdmJsYW5rLiBUaGUgZGlzYWJsZSBoYXMg dG8KPj4gKwkgKiBiZSBsYXN0IChhZnRlciBkcm1faGFuZGxlX3ZibGFua19ldmVudHMpIHNvIHRo YXQgdGhlIHRpbWVzdGFtcAo+PiArCSAqIGlzIGFsd2F5cyBhY2N1cmF0ZS4KPj4gKwkgKi8KPj4g KwlpZiAoZGV2LT52YmxhbmtfZGlzYWJsZV9pbW1lZGlhdGUgJiYKPj4gKwkgICAgZHJtX3ZibGFu a19vZmZkZWxheSA+IDAgJiYKPj4gKwkgICAgIWF0b21pY19yZWFkKCZ2YmxhbmstPnJlZmNvdW50 KSkKPj4gKwkJdmJsYW5rX2Rpc2FibGVfZm4oKHVuc2lnbmVkIGxvbmcpdmJsYW5rKTsKPj4gKwo+ PiAgCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldi0+ZXZlbnRfbG9jaywgaXJxZmxhZ3MpOwo+ Pgo+PiAgCXJldHVybiB0cnVlOwo+PiAtLQo+PiAyLjExLjAKPgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK