From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59EF5C433F5 for ; Fri, 17 Sep 2021 18:28:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24A7961244 for ; Fri, 17 Sep 2021 18:28:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 24A7961244 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 816346EE6A; Fri, 17 Sep 2021 18:28:07 +0000 (UTC) Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id B92A56EE6A for ; Fri, 17 Sep 2021 18:27:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1631903285; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=ehgn3nbxS1ZKthN7E5qnwl/f3AisWEzTHt1QogJw6Vg=; b=hhU5S0yjjFoIVAjaOXkRQI08o9S7UFutdhmrP7bo+Nx3+nUXXf4qUxq2JweVAN0WGvFGxJA9 a4CMLncDxDdICauykcNE/UIP2GHhw4PlKS7tzi5CEUCJr64wqM+pZ+0g/ZsMgxW2ydpEs/a5 i84HZfT0/bO92Xyn0P+XQLr/tg4= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 6144de1fc1b30e2f026a3e4b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 17 Sep 2021 18:27:43 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 3ECCDC4360C; Fri, 17 Sep 2021 18:27:43 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 98B03C4338F; Fri, 17 Sep 2021 18:27:41 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 17 Sep 2021 11:27:41 -0700 From: abhinavk@codeaurora.org To: Sean Paul Cc: dri-devel@lists.freedesktop.org, ppaalanen@gmail.com, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@linux.ie, daniel.vetter@ffwll.ch, Sean Paul Subject: Re: [RESEND PATCH v6 13/14] drm/atomic: Use debug category printer for atomic state printer In-Reply-To: <20210721175526.22020-14-sean@poorly.run> References: <20210721175526.22020-1-sean@poorly.run> <20210721175526.22020-14-sean@poorly.run> Message-ID: <0a77ede789020d44b8e019f57d4c7469@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-07-21 10:55, Sean Paul wrote: > From: Sean Paul > > The atomic state is printed if the DRM_UT_STATE is active, but it's > printed at INFO level. This patch converts it to use the debug > category printer so: > > a- it's consistent with other DRM_UT_STATE logging > b- it's properly routed through drm_trace when introduced > > Signed-off-by: Sean Paul Reviewed-by: Abhinav Kumar > > Changes in v6: > -Added to the set > --- > drivers/gpu/drm/drm_atomic_uapi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_atomic_uapi.c > b/drivers/gpu/drm/drm_atomic_uapi.c > index 7e48d40600ff..7615ded60195 100644 > --- a/drivers/gpu/drm/drm_atomic_uapi.c > +++ b/drivers/gpu/drm/drm_atomic_uapi.c > @@ -1322,7 +1322,7 @@ int drm_mode_atomic_ioctl(struct drm_device *dev, > struct drm_out_fence_state *fence_state; > int ret = 0; > unsigned int i, j, num_fences; > - struct drm_printer p = drm_info_printer(dev->dev); > + struct drm_printer p = drm_debug_category_printer(DRM_UT_STATE, > "commit_state"); > > /* disallow for drivers not supporting atomic: */ > if (!drm_core_check_feature(dev, DRIVER_ATOMIC))