dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/ttm: Use a static string instead of an array of char *
@ 2017-11-28 19:34 Joe Perches
  2017-11-28 19:37 ` Christian König
  0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2017-11-28 19:34 UTC (permalink / raw)
  To: linux-kernel; +Cc: David Airlie, Colin King, dri-devel

Make the object a bit smaller by using a simple string instead
of a format string and array of char *.

$ size drivers/gpu/drm/ttm/ttm_page_alloc_dma.o*
   text	   data	    bss	    dec	    hex	filename
   8820	    216	   4136	  13172	   3374	drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.defconfig.new
   8910	    216	   4136	  13262	   33ce	drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.defconfig.old
  25383	   5044	   4384	  34811	   87fb	drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.allyesconfig.new
  25797	   5428	   4384	  35609	   8b19	drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.allyesconfig.old

Miscellanea:

o The h array had more entries than were emitted, all are now removed

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
index 6b2627fe9bc1..bda00b2ab51c 100644
--- a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
+++ b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
@@ -1244,15 +1244,12 @@ int ttm_dma_page_alloc_debugfs(struct seq_file *m, void *data)
 {
 	struct device_pools *p;
 	struct dma_pool *pool = NULL;
-	char *h[] = {"pool", "refills", "pages freed", "inuse", "available",
-		     "name", "virt", "busaddr"};
 
 	if (!_manager) {
 		seq_printf(m, "No pool allocator running.\n");
 		return 0;
 	}
-	seq_printf(m, "%13s %12s %13s %8s %8s %8s\n",
-		   h[0], h[1], h[2], h[3], h[4], h[5]);
+	seq_printf(m, "         pool      refills   pages freed    inuse available     name\n");
 	mutex_lock(&_manager->lock);
 	list_for_each_entry(p, &_manager->pools, pools) {
 		struct device *dev = p->dev;
-- 
2.15.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/ttm: Use a static string instead of an array of char *
  2017-11-28 19:34 [PATCH] drm/ttm: Use a static string instead of an array of char * Joe Perches
@ 2017-11-28 19:37 ` Christian König
  2017-11-28 20:49   ` Alex Deucher
  0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2017-11-28 19:37 UTC (permalink / raw)
  To: Joe Perches, linux-kernel; +Cc: David Airlie, Colin King, dri-devel

Am 28.11.2017 um 20:34 schrieb Joe Perches:
> Make the object a bit smaller by using a simple string instead
> of a format string and array of char *.
>
> $ size drivers/gpu/drm/ttm/ttm_page_alloc_dma.o*
>     text	   data	    bss	    dec	    hex	filename
>     8820	    216	   4136	  13172	   3374	drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.defconfig.new
>     8910	    216	   4136	  13262	   33ce	drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.defconfig.old
>    25383	   5044	   4384	  34811	   87fb	drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.allyesconfig.new
>    25797	   5428	   4384	  35609	   8b19	drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.allyesconfig.old
>
> Miscellanea:
>
> o The h array had more entries than were emitted, all are now removed
>
> Signed-off-by: Joe Perches <joe@perches.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
> index 6b2627fe9bc1..bda00b2ab51c 100644
> --- a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
> +++ b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
> @@ -1244,15 +1244,12 @@ int ttm_dma_page_alloc_debugfs(struct seq_file *m, void *data)
>   {
>   	struct device_pools *p;
>   	struct dma_pool *pool = NULL;
> -	char *h[] = {"pool", "refills", "pages freed", "inuse", "available",
> -		     "name", "virt", "busaddr"};
>   
>   	if (!_manager) {
>   		seq_printf(m, "No pool allocator running.\n");
>   		return 0;
>   	}
> -	seq_printf(m, "%13s %12s %13s %8s %8s %8s\n",
> -		   h[0], h[1], h[2], h[3], h[4], h[5]);
> +	seq_printf(m, "         pool      refills   pages freed    inuse available     name\n");
>   	mutex_lock(&_manager->lock);
>   	list_for_each_entry(p, &_manager->pools, pools) {
>   		struct device *dev = p->dev;

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] drm/ttm: Use a static string instead of an array of char *
  2017-11-28 19:37 ` Christian König
@ 2017-11-28 20:49   ` Alex Deucher
  0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2017-11-28 20:49 UTC (permalink / raw)
  To: Christian Koenig
  Cc: Joe Perches, David Airlie, LKML, Maling list - DRI developers,
	Colin King

On Tue, Nov 28, 2017 at 2:37 PM, Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
> Am 28.11.2017 um 20:34 schrieb Joe Perches:
>>
>> Make the object a bit smaller by using a simple string instead
>> of a format string and array of char *.
>>
>> $ size drivers/gpu/drm/ttm/ttm_page_alloc_dma.o*
>>     text           data     bss     dec     hex filename
>>     8820            216    4136   13172    3374
>> drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.defconfig.new
>>     8910            216    4136   13262    33ce
>> drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.defconfig.old
>>    25383           5044    4384   34811    87fb
>> drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.allyesconfig.new
>>    25797           5428    4384   35609    8b19
>> drivers/gpu/drm/ttm/ttm_page_alloc_dma.o.allyesconfig.old
>>
>> Miscellanea:
>>
>> o The h array had more entries than were emitted, all are now removed
>>
>> Signed-off-by: Joe Perches <joe@perches.com>
>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>

Applied.  thanks!

Alex

>
>> ---
>>   drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 5 +----
>>   1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
>> b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
>> index 6b2627fe9bc1..bda00b2ab51c 100644
>> --- a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
>> +++ b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
>> @@ -1244,15 +1244,12 @@ int ttm_dma_page_alloc_debugfs(struct seq_file *m,
>> void *data)
>>   {
>>         struct device_pools *p;
>>         struct dma_pool *pool = NULL;
>> -       char *h[] = {"pool", "refills", "pages freed", "inuse",
>> "available",
>> -                    "name", "virt", "busaddr"};
>>         if (!_manager) {
>>                 seq_printf(m, "No pool allocator running.\n");
>>                 return 0;
>>         }
>> -       seq_printf(m, "%13s %12s %13s %8s %8s %8s\n",
>> -                  h[0], h[1], h[2], h[3], h[4], h[5]);
>> +       seq_printf(m, "         pool      refills   pages freed    inuse
>> available     name\n");
>>         mutex_lock(&_manager->lock);
>>         list_for_each_entry(p, &_manager->pools, pools) {
>>                 struct device *dev = p->dev;
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-28 20:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-28 19:34 [PATCH] drm/ttm: Use a static string instead of an array of char * Joe Perches
2017-11-28 19:37 ` Christian König
2017-11-28 20:49   ` Alex Deucher

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).