From: Dmitry Osipenko <digetx@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-tegra@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 2/3] drm/tegra: output: Support DRM bridges
Date: Fri, 17 Apr 2020 22:41:59 +0300 [thread overview]
Message-ID: <0acc35fd-a74b-e726-7a16-55db13265c39@gmail.com> (raw)
In-Reply-To: <20200417193018.GI5861@pendragon.ideasonboard.com>
Hello Laurent,
17.04.2020 22:30, Laurent Pinchart пишет:
...
>> #include <drm/drm_atomic.h>
>> +#include <drm/drm_bridge.h>
>
> You could add a forward declaration of struct drm_bridge instead, that
> can lower the compilation time a little bit.
This include is not only for the struct, but also for the
drm_bridge_attach(). It looks to me that it should be nicer to keep the
include here.
...
>> + port = of_get_child_by_name(output->of_node, "port");
>
> Do you need to check for the presence of a port node first ? Can you
> just check the return value of drm_of_find_panel_or_bridge(), and fall
> back to "nvidia,panel" if it returns -ENODEV ?
Without the check, the drm_of_find_panel_or_bridge() prints a very noisy
error message about missing port node for every output that doesn't have
a graph specified in a device-tree (HDMI, DSI and etc).
https://elixir.bootlin.com/linux/v5.7-rc1/source/drivers/of/property.c#L621
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-18 9:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 17:52 [PATCH v4 0/3] Support DRM bridges on NVIDIA Tegra Dmitry Osipenko
2020-04-17 17:52 ` [PATCH v4 1/3] drm/tegra: output: Don't leak OF node on error Dmitry Osipenko
2020-04-17 17:52 ` [PATCH v4 2/3] drm/tegra: output: Support DRM bridges Dmitry Osipenko
2020-04-17 19:30 ` Laurent Pinchart
2020-04-17 19:41 ` Dmitry Osipenko [this message]
2020-04-17 20:31 ` Laurent Pinchart
2020-04-17 20:52 ` Dmitry Osipenko
2020-04-17 20:58 ` Laurent Pinchart
2020-04-18 14:16 ` Dmitry Osipenko
2020-04-17 17:52 ` [PATCH v4 3/3] drm/tegra: output: rgb: Support LVDS encoder bridge Dmitry Osipenko
2020-04-17 19:24 ` Laurent Pinchart
2020-04-17 20:11 ` Dmitry Osipenko
2020-04-17 20:34 ` Laurent Pinchart
2020-04-17 20:51 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0acc35fd-a74b-e726-7a16-55db13265c39@gmail.com \
--to=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-tegra@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox