From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH 4/4] GPU-DRM-QXL: Adjust checks for null pointers in three functions Date: Thu, 22 Sep 2016 08:23:54 +0200 Message-ID: <0b282ff2-cafe-0b51-912f-def4d840c4ef@users.sourceforge.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: dri-devel@lists.freedesktop.org, Bhaktipriya Shridhar , Daniel Vetter , David Airlie , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Tejun Heo , Thierry Reding Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: dri-devel@lists.freedesktop.org From: Markus Elfring Date: Thu, 22 Sep 2016 08:00:08 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script "checkpatch.pl" can point information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/gpu/drm/qxl/qxl_kms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c index f8f0261..f594430 100644 --- a/drivers/gpu/drm/qxl/qxl_kms.c +++ b/drivers/gpu/drm/qxl/qxl_kms.c @@ -149,7 +149,7 @@ static int qxl_device_init(struct qxl_device *qdev, io_mapping_create_wc(qdev->surfaceram_base, qdev->surfaceram_size); } - if (qdev->surface_mapping == NULL) { + if (!qdev->surface_mapping) { /* 64bit surface bar not present (or mapping failed) */ sb = 1; qdev->surfaceram_base = pci_resource_start(pdev, sb); @@ -288,7 +288,7 @@ int qxl_driver_unload(struct drm_device *dev) { struct qxl_device *qdev = dev->dev_private; - if (qdev == NULL) + if (!qdev) return 0; drm_vblank_cleanup(dev); @@ -307,7 +307,7 @@ int qxl_driver_load(struct drm_device *dev, unsigned long flags) int r; qdev = kzalloc(sizeof(*qdev), GFP_KERNEL); - if (qdev == NULL) + if (!qdev) return -ENOMEM; dev->dev_private = qdev; -- 2.10.0