From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>,
Deepak R Varma <mh12gx2825@gmail.com>
Cc: "David Airlie" <airlied@linux.ie>,
daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org, melissa.srw@gmail.com,
outreachy-kernel@googlegroups.com,
dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [Outreachy kernel] [PATCH] drm/amdgpu: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe()
Date: Sat, 31 Oct 2020 04:52:50 -0700 [thread overview]
Message-ID: <0b818156537f354904938f437cbb9dd02e765653.camel@perches.com> (raw)
In-Reply-To: <20201030080316.GA1612206@kroah.com>
On Fri, 2020-10-30 at 09:03 +0100, Greg KH wrote:
> On Fri, Oct 30, 2020 at 01:27:16PM +0530, Deepak R Varma wrote:
> > On Fri, Oct 30, 2020 at 08:11:20AM +0100, Greg KH wrote:
> > > On Fri, Oct 30, 2020 at 08:52:45AM +0530, Deepak R Varma wrote:
> > > > Using DEFINE_DEBUGFS_ATTRIBUTE macro with debugfs_create_file_unsafe()
> > > > function in place of the debugfs_create_file() function will make the
> > > > file operation struct "reset" aware of the file's lifetime. Additional
> > > > details here: https://lists.archive.carbon60.com/linux/kernel/2369498
> > > >
> > > > Issue reported by Coccinelle script:
> > > > scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
[]
> There is a reason we didn't just do a global search/replace for this in
> the kernel when the new functions were added, so I don't know why
> checkpatch is now saying it must be done.
I think it's not a checkpatch warning here.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-31 11:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 3:22 [PATCH] drm/amdgpu: use DEFINE_DEBUGFS_ATTRIBUTE with debugfs_create_file_unsafe() Deepak R Varma
2020-10-30 7:11 ` [Outreachy kernel] " Greg KH
2020-10-30 7:57 ` Deepak R Varma
2020-10-30 8:00 ` Christian König
2020-10-30 8:25 ` Greg KH
2020-10-30 9:15 ` Daniel Vetter
2020-10-30 9:24 ` Daniel Vetter
2020-10-30 12:55 ` Deepak R Varma
2020-10-30 9:53 ` Christian König
2020-10-30 8:03 ` Greg KH
2020-10-30 8:17 ` Sumera Priyadarsini
2020-10-30 8:24 ` Greg KH
2020-10-30 10:20 ` Julia Lawall
2020-10-31 11:52 ` Joe Perches [this message]
2020-10-31 12:01 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b818156537f354904938f437cbb9dd02e765653.camel@perches.com \
--to=joe@perches.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=melissa.srw@gmail.com \
--cc=mh12gx2825@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox