From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E9C3C433E3 for ; Wed, 19 Aug 2020 06:57:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0ADE82083B for ; Wed, 19 Aug 2020 06:57:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="MIiokSe9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0ADE82083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D3B596E1ED; Wed, 19 Aug 2020 06:57:32 +0000 (UTC) Received: from mail29.static.mailgun.info (mail29.static.mailgun.info [104.130.122.29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E93389B68 for ; Tue, 18 Aug 2020 15:18:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597763921; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=llOXz6hHf939lRgjzq6PQgYsFaUkZxMefMQodFWY1Y4=; b=MIiokSe9Ypc9Zm2BTxgRmPOzeuAH3UmrhJIitXMxRZaC286xhRYIFtm3j+7++rs8pk1sT5ZW ibp1uWEgcB/TdWmqe+JToZvmdlrnZG8jd/gBeRLAJATNeB7m2NiXf6vXr24MS1Xr20le5EMZ fV+A9EcySvz4znF/o9bmbEZPoi8= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n08.prod.us-west-2.postgun.com with SMTP id 5f3bf14f4c787f237b1cf4e9 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 18 Aug 2020 15:18:39 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BBC2DC433AF; Tue, 18 Aug 2020 15:18:38 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 49A95C433CA; Tue, 18 Aug 2020 15:18:37 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 18 Aug 2020 20:48:37 +0530 From: Sai Prakash Ranjan To: Rob Clark Subject: Re: [v2] drm/msm: add shutdown support for display platform_driver In-Reply-To: References: <1591009402-681-1-git-send-email-mkrishn@codeaurora.org> Message-ID: <0c3a5b78537c659f49037e3f9d0d8888@codeaurora.org> X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-Mailman-Approved-At: Wed, 19 Aug 2020 06:56:51 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krishna Manikandan , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , Linux Kernel Mailing List , dri-devel , linux-arm-msm-owner@vger.kernel.org, Sean Paul , Kalyan Thota , "Kristian H. Kristensen" , freedreno , Matthias Kaehlcke , Emil Velikov Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2020-08-18 20:42, Rob Clark wrote: > On Tue, Aug 18, 2020 at 3:03 AM Sai Prakash Ranjan > wrote: >> >> Hi, >> >> On 2020-06-01 16:33, Krishna Manikandan wrote: >> > Define shutdown callback for display drm driver, >> > so as to disable all the CRTCS when shutdown >> > notification is received by the driver. >> > >> > This change will turn off the timing engine so >> > that no display transactions are requested >> > while mmu translations are getting disabled >> > during reboot sequence. >> > >> > Signed-off-by: Krishna Manikandan >> > >> > Changes in v2: >> > - Remove NULL check from msm_pdev_shutdown (Stephen Boyd) >> > - Change commit text to reflect when this issue >> > was uncovered (Sai Prakash Ranjan) >> > --- >> > drivers/gpu/drm/msm/msm_drv.c | 8 ++++++++ >> > 1 file changed, 8 insertions(+) >> > >> > diff --git a/drivers/gpu/drm/msm/msm_drv.c >> > b/drivers/gpu/drm/msm/msm_drv.c >> > index e4b750b..94e3963 100644 >> > --- a/drivers/gpu/drm/msm/msm_drv.c >> > +++ b/drivers/gpu/drm/msm/msm_drv.c >> > @@ -1322,6 +1322,13 @@ static int msm_pdev_remove(struct >> > platform_device *pdev) >> > return 0; >> > } >> > >> > +static void msm_pdev_shutdown(struct platform_device *pdev) >> > +{ >> > + struct drm_device *drm = platform_get_drvdata(pdev); >> > + >> > + drm_atomic_helper_shutdown(drm); >> > +} >> > + >> > static const struct of_device_id dt_match[] = { >> > { .compatible = "qcom,mdp4", .data = (void *)KMS_MDP4 }, >> > { .compatible = "qcom,mdss", .data = (void *)KMS_MDP5 }, >> > @@ -1334,6 +1341,7 @@ static int msm_pdev_remove(struct platform_device >> > *pdev) >> > static struct platform_driver msm_platform_driver = { >> > .probe = msm_pdev_probe, >> > .remove = msm_pdev_remove, >> > + .shutdown = msm_pdev_shutdown, >> > .driver = { >> > .name = "msm", >> > .of_match_table = dt_match, >> >> Any more comments on this patch? > > sorry, I managed to overlook this earlier.. I've pulled it in to > msm-next > No problem, thanks Rob. -Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel