From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB616C433F5 for ; Sat, 19 Feb 2022 10:02:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4846A10F671; Sat, 19 Feb 2022 10:02:00 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id B970510E1F7 for ; Thu, 17 Feb 2022 17:00:59 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dmitry.osipenko) with ESMTPSA id A6F431F46171 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1645117258; bh=ff3TSiMV7RvAbS0hNd/AGstmXBT++vNiyhhx50+xrd8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dBdEbVdp2EEfpi/vkF5YuEEUhxfieguPC+aO0KJIceXvBmWhA4SPcAdagW1ZAQz1H xE6PRIb1Fq2LB4lvWqaF5kQti083FrfgjZsN6EgfyHbZqKoylouXB6RZdrUgPU7vRX NCWZ1VP4+ZkMG/1VZC1W0Tqge1pfUomwOoLsmYgCpWbQgRL69zL2jlucUzRKvF3cts xuuW80kMPuliMf04HN+qIuaKU8cTT8DS3o37OM1gvPzDuGm9GxIcJkGi7OKldabNPc 0qZFmCCDMJ+vA1mtStR9RdXedEbUJRBTvH8iVjiMV40d3ZyQPm4xwy9U1TGxt6s0U0 m1lV+rXcuBNpw== Message-ID: <0c6bd002-dbb3-aa44-9508-974c3ebda778@collabora.com> Date: Thu, 17 Feb 2022 20:00:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v6 13/23] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always Content-Language: en-US To: Sascha Hauer References: <20220217082954.2967889-1-s.hauer@pengutronix.de> <20220217082954.2967889-14-s.hauer@pengutronix.de> <20220217151259.GT18637@pengutronix.de> From: Dmitry Osipenko In-Reply-To: <20220217151259.GT18637@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Sat, 19 Feb 2022 10:01:55 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , kernel@pengutronix.de, Douglas Anderson , dri-devel@lists.freedesktop.org, Sandy Huang , linux-rockchip@lists.infradead.org, Michael Riesch , Peter Geis , Yakir Yang , Andy Yan , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" 17.02.2022 18:12, Sascha Hauer пишет: > On Thu, Feb 17, 2022 at 05:00:37PM +0300, Dmitry Osipenko wrote: >> 17.02.2022 11:29, Sascha Hauer пишет: >>> From: Douglas Anderson >>> >>> Jitter was improved by lowering the MPLL bandwidth to account for high >>> frequency noise in the rk3288 PLL. In each case MPLL bandwidth was >>> lowered only enough to get us a comfortable margin. We believe that >>> lowering the bandwidth like this is safe given sufficient testing. >> >> There are no device-trees that use "rockchip,rk3288-cru", AFAICS.. > > What do you mean? In my tree I have: > > arch/arm/boot/dts/rk3288.dtsi:863: compatible = "rockchip,rk3288-cru"; > drivers/clk/rockchip/clk-rk3288.c:985:CLK_OF_DECLARE(rk3288_cru, "rockchip,rk3288-cru", rk3288_clk_init); Oh, it is ARM32, I was looking at ARM64 only. My bad. >> Was this change tested on a non-RK3288 devices? > > Yes, on a rk3568 ;) > > The patch has been posted back in 2015 and was added to the Rockchip > downstream kernel in 2016. I don't know how thoroughly Rockchip tests > their kernels, but I assume the patch wouldn't be there if it caused > any problems. Thank you for the clarification.